Skip to content

CCM-15241: Terraform changes to configuration#260

Merged
nhsd-angel-pastor merged 3 commits intomainfrom
feature/CCM-15241-tf-config
Mar 27, 2026
Merged

CCM-15241: Terraform changes to configuration#260
nhsd-angel-pastor merged 3 commits intomainfrom
feature/CCM-15241-tf-config

Conversation

@nhsd-angel-pastor
Copy link
Copy Markdown
Contributor

@nhsd-angel-pastor nhsd-angel-pastor commented Mar 25, 2026

Description

To speed up component tests in DEV environments, extracted the lambda timeout and SQS visibility timeout (see https://github.com/NHSDigital/nhs-notify-internal/pull/611 for the default values). The lambdas I excluded are:

  • MESH Poll: In Comms-mgr we set up the lambda with the timeout of 15 min (runtime of 13), here is set to 5 min (runtime of 4) with a rate of 5 minutes.
  • Report generation: As it runs queries in Athena this can take longer. In addition it has the variables athena_query_max_polling_attempts and athena_query_polling_time_seconds that depends on the timeout.

See comment for more details

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-15241-tf-config branch 4 times, most recently from 6e95e61 to 8c9ea2e Compare March 26, 2026 17:41
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-15241-tf-config branch from 8c9ea2e to b4e2391 Compare March 27, 2026 09:10
@nhsd-angel-pastor nhsd-angel-pastor marked this pull request as ready for review March 27, 2026 12:31
@nhsd-angel-pastor nhsd-angel-pastor requested a review from a team as a code owner March 27, 2026 12:31
@nhsd-angel-pastor nhsd-angel-pastor merged commit 2676deb into main Mar 27, 2026
117 of 118 checks passed
@nhsd-angel-pastor nhsd-angel-pastor deleted the feature/CCM-15241-tf-config branch March 27, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants