Terraform fixes

Author: stevebux

infrastructure/terraform/components/api/README.md

@@ -45,7 +45,7 @@ No requirements.
 | <a name="module_kms"></a> [kms](#module\_kms) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-kms.zip | n/a |
 | <a name="module_letter_status_update"></a> [letter\_status\_update](#module\_letter\_status\_update) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip | n/a |
 | <a name="module_letter_status_updates_queue"></a> [letter\_status\_updates\_queue](#module\_letter\_status\_updates\_queue) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-sqs.zip | n/a |
-| <a name="module_letter_stream_handler"></a> [letter\_stream\_handler](#module\_letter\_stream\_handler) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
+| <a name="module_letter_stream_forwarder"></a> [letter\_stream\_forwarder](#module\_letter\_stream\_forwarder) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
 | <a name="module_letter_updates_transformer"></a> [letter\_updates\_transformer](#module\_letter\_updates\_transformer) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
 | <a name="module_logging_bucket"></a> [logging\_bucket](#module\_logging\_bucket) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-s3bucket.zip | n/a |
 | <a name="module_patch_letter"></a> [patch\_letter](#module\_patch\_letter) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |

infrastructure/terraform/components/api/module_lambda_letter_stream_forwarder.tf

@@ -1,4 +1,4 @@
-module "letter_stream_handler" {
+module "letter_stream_forwarder" {
   source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip"
 
   function_name = "letter-stream-forwarder"

infrastructure/terraform/components/api/module_lambda_letter_updates_transformer.tf

@@ -57,7 +57,7 @@ data "aws_iam_policy_document" "letter_updates_transformer_lambda" {
 
 resource "aws_lambda_event_source_mapping" "letter_updates_transformer_kinesis" {
   event_source_arn                     = aws_kinesis_stream.letter_change_stream.arn
-  function_name                        = module.v.function_arn
+  function_name                        = module.letter_updates_transformer.function_arn
   starting_position                    = "LATEST"
   batch_size                           = 10
   maximum_batching_window_in_seconds   = 1