Skip to content

CCM-10160 minor fixes to workflows and precommits#157

Merged
masl2 merged 7 commits intomainfrom
CCM-10160_minorFixes
Dec 4, 2025
Merged

CCM-10160 minor fixes to workflows and precommits#157
masl2 merged 7 commits intomainfrom
CCM-10160_minorFixes

Conversation

@aidenvaines-cgi
Copy link
Contributor

Description

Spotted a couple of minor problems with

  • Precommit hooks trying to overwrite package-lock
  • missing role and project name overrides

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@aidenvaines-cgi aidenvaines-cgi requested review from a team as code owners September 17, 2025 13:06
@sonarqubecloud
Copy link

sidnhs
sidnhs previously approved these changes Sep 17, 2025
masl2
masl2 previously requested changes Sep 24, 2025
masl2
masl2 previously approved these changes Oct 28, 2025
m-houston
m-houston previously approved these changes Nov 10, 2025
# Conflicts:
#	.github/workflows/pr_closed.yaml
@m-houston m-houston dismissed stale reviews from masl2 and themself via 6f56fc2 November 20, 2025 10:11
@masl2 masl2 enabled auto-merge (squash) November 27, 2025 17:06
@masl2 masl2 merged commit d6da5d5 into main Dec 4, 2025
32 checks passed
@masl2 masl2 deleted the CCM-10160_minorFixes branch December 4, 2025 13:17
masl2 added a commit that referenced this pull request Jan 5, 2026
Co-authored-by: Mark Slowey <113013138+masl2@users.noreply.github.com>
Co-authored-by: Mike Houston <60653100+m-houston@users.noreply.github.com>
Co-authored-by: Mike Houston <michael.houston4@nhs.net>
Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants