Skip to content

Comments

CCM-11938: Move Proxygen Deploy to Internal#177

Merged
sidnhs merged 6 commits intomainfrom
feature/CCM-11938_workflow
Oct 8, 2025
Merged

CCM-11938: Move Proxygen Deploy to Internal#177
sidnhs merged 6 commits intomainfrom
feature/CCM-11938_workflow

Conversation

@sidnhs
Copy link
Contributor

@sidnhs sidnhs commented Oct 1, 2025

Description

CI/CD workflow: https://github.com/NHSDigital/nhs-notify-supplier-api/actions/runs/18226945316
Proxy job that got kicked off with inputs: https://github.com/NHSDigital/nhs-notify-internal/actions/runs/18227036444

Manual Proxy workflow for internal-dev with existing PR detected: https://github.com/NHSDigital/nhs-notify-supplier-api/actions/runs/18226589311
Proxy job that got kicked off with inputs: https://github.com/NHSDigital/nhs-notify-internal/actions/runs/18226614817

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

APIM_ENV="${{ inputs.environment }}"
fi

if [ -z "${{ inputs.environment }}" ]; then

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections

<!--SONAR_ISSUE_KEY:AZmlk_Rg-Co9hXBqniqH-->Change this workflow to not use user-controlled data directly in a run block. <p>See more on <a href="https://sonarcloud.io/project/issues?id=NHSDigital_nhs-notify-supplier-api&issues=AZmlk_Rg-Co9hXBqniqH&open=AZmlk_Rg-Co9hXBqniqH&pullRequest=177">SonarQube Cloud</a></p>
if [ -z "${{ inputs.environment }}" ]; then
ENVIRONMENT="internal-dev"
else
ENVIRONMENT="${{ inputs.environment }}"

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections

<!--SONAR_ISSUE_KEY:AZmlk_Rg-Co9hXBqniqI-->Change this workflow to not use user-controlled data directly in a run block. <p>See more on <a href="https://sonarcloud.io/project/issues?id=NHSDigital_nhs-notify-supplier-api&issues=AZmlk_Rg-Co9hXBqniqI&open=AZmlk_Rg-Co9hXBqniqI&pullRequest=177">SonarQube Cloud</a></p>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sidnhs sidnhs force-pushed the feature/CCM-11938_workflow branch 4 times, most recently from b2515b0 to 871c720 Compare October 3, 2025 15:50
@sidnhs sidnhs marked this pull request as ready for review October 3, 2025 15:53
@sidnhs sidnhs requested a review from a team as a code owner October 3, 2025 15:53
@sidnhs sidnhs changed the title CCM-11938: try CCM-11938: Move Proxygen Deploy to Internal Oct 6, 2025
@sidnhs sidnhs force-pushed the feature/CCM-11938_workflow branch from c97f118 to e3ffe7a Compare October 8, 2025 10:25
@sidnhs sidnhs enabled auto-merge (squash) October 8, 2025 11:18
@sidnhs sidnhs disabled auto-merge October 8, 2025 11:26
@sidnhs sidnhs merged commit 76addbe into main Oct 8, 2025
136 of 140 checks passed
@sidnhs sidnhs deleted the feature/CCM-11938_workflow branch October 8, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants