Skip to content

Fix/internal event datastore dep#484

Merged
masl2 merged 5 commits intomainfrom
fix/internal-event-datastore-dep
Mar 27, 2026
Merged

Fix/internal event datastore dep#484
masl2 merged 5 commits intomainfrom
fix/internal-event-datastore-dep

Conversation

@masl2
Copy link
Copy Markdown
Contributor

@masl2 masl2 commented Mar 24, 2026

Description

Introducing the letter to letter event mapper into the event package created a dependency on the internal/datastore to support the typing.

However, external importers (digital letters) do not have access to this internal dependency. Therefore the mapper has been moved out of the event package.

To avoid circular package dependencies this has been placed into a new internal package

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@masl2 masl2 requested a review from a team as a code owner March 24, 2026 12:05
@masl2 masl2 merged commit 2ab5462 into main Mar 27, 2026
37 checks passed
@masl2 masl2 deleted the fix/internal-event-datastore-dep branch March 27, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants