Developer phase banner, primary nav style changes and new page template #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCM-5869: Create accessibility statement page (NHSDigital#58)
…llel send' feature mention.
Added mention of 'message cascades' in routing plan content for 'para…
- changes to /using-nhs-notify/mesh to match MESH guidance - sender IDs changed to sender names
Message and channel status page + other edits
…mplates, /using-nhs-notify/text-message-templates and /using-nhs-notify/letter-templates. These are based on the Confluence pages https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?spaceKey=RIS&title=3.8+Creating+letter+templates onwards, with some minor tweaks to word ordering. Romy has approved this content now. Uploaded the standardised Word doc templates for all 4 channels to /assets/worddocs, and linked to these. Craig in cyber security approved this approach (see ticket for screenshot). Updated /using-nhs-notify/personalisation in line with the Confluence page. The FAQs from onboarding indicated there's a user need to provide the PDS personalisation fields. I also added content on how users provide their own personalisation data, in line with Tan's Confluence page https://nhsd-confluence.digital.nhs.uk/display/RIS/NHS+Notify+%7C+Personalisation+Fields. In /pricing/text-messages, I replaced 'it will count as more than one message' with 'it will be charged as more than one message'. This was prompted by a comment from Romy on the text message template content. I tweaked the content to match the later version of the UI prototype, which we based on findings from user research.
…lisation-update Creating templates guidance + personalisation updates + text message pricing update
Removed mention of bank holidays from emails and text message delivery times
… templates. Updated link text for the 4 template pages in the Using NHS Notify parent page - removed 'Creating...' from the start of each link.
…ks on /using-nhs-notify.
…l lower case. Updated downloadable links to follow the approach Jake researched, for example [letter template]({% link assets/worddocs/letter-template-nhs-notify.docx %})
…/letter-templates.
Ignoring the 'English usage commit check' as it's not consistent to the GOV.UK / NHS style guide. 'URL' is to be written in full capitals.
Includes: - Noto - URL - ctrl - pending_enrichment - unnotified - permanent_failure - temporary_failure - technical_failure - precompiled - validation_failed - fullName - namePrefix - clientRef
…tch-1 Update accept.txt
…nce your letter has been sent, it can take...' with 'Once you've provided us with recipients' NHS numbers, it can take up to 2 working days for our suppliers to dispatch your letter'. I also added anchor links to the top of the same page, /using-nhs-notify/delivery-times, to make navigation easier.
Letter delivery times update + anchor links
…act details that are outside of PDS.
PDS override content + page name tidy-up
Update from upstream
… from the bulleted list of personalisation fields from PDS as these are for internal use only. Restructured the first paragraph under ### Personal Demographics Service (PDS) personalisation fields. This was based off a conversation with Jake and it aims to clarify the link between PDS, NHS numbers and personalisation fields.
…ded the line 'flex-wrap: wrap;' in the following code:
.nhsuk-header__navigation-list {
justify-content: flex-start;
flex-wrap: wrap;
}
This is an interim step to make the main nav list items wrap correctly when the site is viewed on a mobile device. It's not our ultimate solution but it makes the site more mobile responsive and accessible.
PDS personalisation fields updates + main nav wrapping
…ions. Removed date of birth as as an example of a column header in a MESH request.
commit 7b904fc Author: Ross Buggins <[email protected]> Date: Tue Nov 19 17:02:42 2024 +0000 Quick and easy js to auto hide. commit 8aed356 Author: Jake Cosgrove <[email protected]> Date: Tue Nov 19 16:05:22 2024 +0000 Developer banner and new site banner commit a3d47d2 Author: Jake Cosgrove <[email protected]> Date: Mon Nov 11 15:47:17 2024 +0000 removed phase banner and underlines from primary nav list items when hovered commit 3a30f41 Author: Jake Cosgrove <[email protected]> Date: Mon Nov 11 13:50:40 2024 +0000 removed border from phase banner commit fc61be5 Author: Jake Cosgrove <[email protected]> Date: Fri Nov 8 16:32:05 2024 +0000 Added phase banner component and related sass. Added new template for including pages of content that does not need a side-navigation. commit 45d34e6 Author: Jake Cosgrove <[email protected]> Date: Tue Nov 5 21:59:47 2024 +0000 two-third column tests
Squashed commit of the following
Phase banner quick fix
emmagifford
previously approved these changes
Dec 13, 2024
Contributor
emmagifford
left a comment
emmagifford
left a comment
There was a problem hiding this comment.
Happy to approve!
I've 2i checked the layout changes:
- phase banner for the developer site looks good and the link to the live site works
- page headings in the banner at the top are now spaced equally and underlined (underline removed when hovered over) to match the NHS digital service manual component
- /support and /get-started use the new no side nav page layout as they have no sub-pages - this layout displays as expected
Content changes:
- /delivery-times incorporates content changes from a previous PR I made in the dev repo - bullets with anchor links at the start to the 4 different channels, and the updated time frame for letter dispatch
- /personalisation - some personalisation fields removed from the list, an update to the paragraph starting 'NHS Notify uses the…', 'NHS Notify' added to the API and MESH subheadings, 'column names should start with' updated, 'dateOfBirth' typo removed from column name example, acronym markdown removed
- MESH guidance link added to /using-nhs-notify/mesh
- PDS H3 updated to H2
- line removed from /using-nhs-notify/message-status
- /tell-us-who-you-want-to-message - new para added on providing your own contact details
…ream Robu6/2024 12 13/merge in upstream
…leased by developer
Hidden 'developer' phase banner
alexcolbeck1
requested changes
Dec 16, 2024
Contributor
|
Superceded by PR75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
Context
Developer 'Phase banner' - differentiates the pre-production NHS Notify site from the live site
Primary navigation changes - styled to match NHS UK Design system header component
No side nav page - the support and get started pages do not need a side navigation as they do not have any sub-pages
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.