simplify zod json preprocessor

Author: alexnuttall

lambdas/backend-api/src/__tests__/utils/zod-json-preprocessor.test.ts

@@ -18,18 +18,6 @@ describe('parseJsonPreprocessor', () => {
     expect(val).toEqual({ name: 'example' });
   });
 
-  it('should return value when value is not a string', () => {
-    const addIssue = jest.fn();
-
-    const context = mock<z.RefinementCtx>({ addIssue });
-
-    const val = parseJsonPreprocessor({}, context);
-
-    expect(addIssue).not.toHaveBeenCalled();
-
-    expect(val).toEqual({});
-  });
-
   it('should add error to context when unable to parse JSON', () => {
     const addIssue = jest.fn();
 

lambdas/backend-api/src/utils/zod-json-preprocessor.ts

@@ -1,15 +1,13 @@
 import { z } from 'zod';
 
 export const parseJsonPreprocessor = (value: unknown, ctx: z.RefinementCtx) => {
-  if (typeof value === 'string') {
-    try {
-      return JSON.parse(value);
-    } catch (error) {
-      ctx.addIssue({
-        code: z.ZodIssueCode.custom,
-        message: (error as Error)?.message,
-      });
-    }
+  try {
+    return JSON.parse(value as string);
+  } catch (error) {
+    ctx.addIssue({
+      code: z.ZodIssueCode.custom,
+      message: (error as Error)?.message,
+    });
   }
 
   return value;