CCM-8574: add more e2e tests

Author: harrim91

tests/test-team/fixtures/pdf-upload/multipart-pdf-letter-fixtures.ts

@@ -44,12 +44,20 @@ const getFile = (directory: string, filename: string) => {
 export const pdfUploadFixtures = {
   withPersonalisation: {
     csv: getFile('with-personalisation', 'test-data.csv'),
+    csvEmptyParams: getFile('with-personalisation', 'empty-params.csv'),
+    csvNonsenseParams: getFile('with-personalisation', 'nonsense.csv'),
     csvWrongParams: getFile('with-personalisation', 'wrong-params.csv'),
     passwordPdf: getFile('with-personalisation', 'password.pdf'),
     pdf: getFile('with-personalisation', 'template.pdf'),
+    pdfEmptyParams: getFile('with-personalisation', 'empty-params.pdf'),
+    pdfNonsenseParams: getFile('with-personalisation', 'nonsense.pdf'),
   },
   noCustomPersonalisation: {
     pdf: getFile('no-custom-personalisation', 'template.pdf'),
     passwordPdf: getFile('no-custom-personalisation', 'password.pdf'),
+    pdfIncompleteAddress: getFile(
+      'no-custom-personalisation',
+      'incomplete-address.pdf'
+    ),
   },
 };

tests/test-team/fixtures/pdf-upload/no-custom-personalisation/incomplete-address.pdf

@@ -0,0 +1,2 @@
+Personalisation field,Short length data example,Medium length data example,Long length data example
+,short example,middle example,super long example

tests/test-team/fixtures/pdf-upload/with-personalisation/empty-params.csv

@@ -0,0 +1,2 @@
+Personalisation field,Short length data example,Medium length data example,Long length data example
+!!!,short example,middle example,super long example

tests/test-team/fixtures/pdf-upload/with-personalisation/empty-params.pdf

@@ -387,6 +387,145 @@ test.describe('letter file validation', () => {
       expect(template.csvHeaders).toBeUndefined();
     }).toPass({ timeout: 10_000 });
   });
-});
 
-// TODO: Add test for parameter formatting in pdf
+  test('validation fails if pdf has incomplete address', async ({ page }) => {
+    const createTemplatePage = new TemplateMgmtCreateLetterPage(page);
+
+    await createTemplatePage.loadPage();
+
+    await createTemplatePage.nameInput.fill('Incomplete address');
+
+    await createTemplatePage.setPdfFile(
+      pdfUploadFixtures.noCustomPersonalisation.pdfIncompleteAddress.filepath
+    );
+
+    await createTemplatePage.clickSaveAndPreviewButton();
+
+    await expect(page).toHaveURL(TemplateMgmtPreviewLetterPage.urlRegexp);
+
+    const maybeTemplateId = TemplateMgmtPreviewLetterPage.getTemplateId(
+      page.url()
+    );
+
+    expect(maybeTemplateId).not.toBeUndefined();
+
+    const templateId = maybeTemplateId as string;
+
+    const key = {
+      id: templateId,
+      owner: user.userId,
+    };
+
+    templateStorageHelper.addAdHocTemplateKey(key);
+
+    await expect(async () => {
+      const template = await templateStorageHelper.getTemplate({
+        id: templateId,
+        owner: user.userId,
+      });
+
+      expect(template.files?.pdfTemplate?.virusScanStatus).toBe('PASSED');
+      expect(template.templateStatus).toBe('VALIDATION_FAILED');
+      expect(template.personalisationParameters).toBeUndefined();
+      expect(template.csvHeaders).toBeUndefined();
+    }).toPass({ timeout: 10_000 });
+  });
+
+  test('validation fails if pdf has empty parameters', async ({ page }) => {
+    const createTemplatePage = new TemplateMgmtCreateLetterPage(page);
+
+    await createTemplatePage.loadPage();
+
+    await createTemplatePage.nameInput.fill('With empty parameters');
+
+    await createTemplatePage.setPdfFile(
+      pdfUploadFixtures.withPersonalisation.pdfEmptyParams.filepath
+    );
+
+    await createTemplatePage.setCsvFile(
+      pdfUploadFixtures.withPersonalisation.csvEmptyParams.filepath
+    );
+
+    await createTemplatePage.clickSaveAndPreviewButton();
+
+    await expect(page).toHaveURL(TemplateMgmtPreviewLetterPage.urlRegexp);
+
+    const maybeTemplateId = TemplateMgmtPreviewLetterPage.getTemplateId(
+      page.url()
+    );
+
+    expect(maybeTemplateId).not.toBeUndefined();
+
+    const templateId = maybeTemplateId as string;
+
+    const key = {
+      id: templateId,
+      owner: user.userId,
+    };
+
+    templateStorageHelper.addAdHocTemplateKey(key);
+
+    await expect(async () => {
+      const template = await templateStorageHelper.getTemplate({
+        id: templateId,
+        owner: user.userId,
+      });
+
+      expect(template.files?.pdfTemplate?.virusScanStatus).toBe('PASSED');
+      expect(template.files?.testDataCsv?.virusScanStatus).toBe('PASSED');
+      expect(template.templateStatus).toBe('VALIDATION_FAILED');
+      expect(template.personalisationParameters).toBeUndefined();
+      expect(template.csvHeaders).toBeUndefined();
+    }).toPass({ timeout: 10_000 });
+  });
+
+  test('validation fails if pdf has non-sensible parameters', async ({
+    page,
+  }) => {
+    const createTemplatePage = new TemplateMgmtCreateLetterPage(page);
+
+    await createTemplatePage.loadPage();
+
+    await createTemplatePage.nameInput.fill('With nonsense parameters');
+
+    await createTemplatePage.setPdfFile(
+      pdfUploadFixtures.withPersonalisation.pdfNonsenseParams.filepath
+    );
+
+    await createTemplatePage.setCsvFile(
+      pdfUploadFixtures.withPersonalisation.csvNonsenseParams.filepath
+    );
+
+    await createTemplatePage.clickSaveAndPreviewButton();
+
+    await expect(page).toHaveURL(TemplateMgmtPreviewLetterPage.urlRegexp);
+
+    const maybeTemplateId = TemplateMgmtPreviewLetterPage.getTemplateId(
+      page.url()
+    );
+
+    expect(maybeTemplateId).not.toBeUndefined();
+
+    const templateId = maybeTemplateId as string;
+
+    const key = {
+      id: templateId,
+      owner: user.userId,
+    };
+
+    templateStorageHelper.addAdHocTemplateKey(key);
+
+    await expect(async () => {
+      const template = await templateStorageHelper.getTemplate({
+        id: templateId,
+        owner: user.userId,
+      });
+
+      expect(template.files?.pdfTemplate?.virusScanStatus).toBe('PASSED');
+      expect(template.files?.testDataCsv?.virusScanStatus).toBe('PASSED');
+      expect(template.templateStatus).toBe('VALIDATION_FAILED');
+      expect(template.personalisationParameters).toBeUndefined();
+      expect(template.csvHeaders).toBeUndefined();
+    }).toPass({ timeout: 10_000 });
+  });
+});