CCM-12744: tests

Author: harrim91

lambdas/backend-client/src/__tests__/routing-config-api-client.test.ts

@@ -4,11 +4,9 @@ import {
   httpClient,
 } from '../routing-config-api-client';
 import { RoutingConfig, RoutingConfigStatus } from '../types/generated';
-import { ErrorCase } from '../types/error-cases';
 
 const validRoutingConfigId = '2a4b6c8d-0e1f-4a2b-9c3d-5e6f7a8b9c0d';
 const notFoundRoutingConfigId = '3b5d7f9a-1c2e-4b3d-8f0a-6e7d8c9b0a1f';
-const invalidRoutingConfigId = 'not-a-uuid';
 
 describe('RoutingConfigurationApiClient', () => {
   const axiosMock = new MockAdapter(httpClient);
@@ -141,21 +139,6 @@ describe('RoutingConfigurationApiClient', () => {
       expect(axiosMock.history.get.length).toBe(1);
     });
 
-    it('should return error for invalid routing config ID', async () => {
-      const response = await client.get('mock-token', invalidRoutingConfigId);
-
-      expect(response.error).toEqual({
-        errorMeta: {
-          code: ErrorCase.VALIDATION_FAILED,
-          description: 'Invalid routing configuration ID format',
-          details: { id: invalidRoutingConfigId },
-        },
-        actualError: undefined,
-      });
-      expect(response.data).toBeUndefined();
-      expect(axiosMock.history.get.length).toBe(0);
-    });
-
     it('should return routing configuration on success', async () => {
       const data = {
         id: validRoutingConfigId,
@@ -294,34 +277,6 @@ describe('RoutingConfigurationApiClient', () => {
       expect(axiosMock.history.patch.length).toBe(1);
     });
 
-    it('should return error for invalid routing config ID', async () => {
-      const body = {
-        id: invalidRoutingConfigId,
-        name: 'Test plan',
-        campaignId: 'campaign-1',
-        cascade: [],
-        cascadeGroupOverrides: [],
-      };
-
-      const response = await client.update(
-        'mock-token',
-        invalidRoutingConfigId,
-        body,
-        42
-      );
-
-      expect(response.error).toEqual({
-        errorMeta: {
-          code: ErrorCase.VALIDATION_FAILED,
-          description: 'Invalid routing configuration ID format',
-          details: { id: invalidRoutingConfigId },
-        },
-        actualError: undefined,
-      });
-      expect(response.data).toBeUndefined();
-      expect(axiosMock.history.patch.length).toBe(0);
-    });
-
     it('should return updated routing configuration on success', async () => {
       const body = {
         id: validRoutingConfigId,

lambdas/backend-client/src/routing-config-api-client.ts

@@ -11,15 +11,11 @@ import type {
   PatchV1RoutingConfigurationByRoutingConfigIdData,
   UpdateRoutingConfig,
 } from './types/generated';
-import { ErrorCase } from './types/error-cases';
 import { catchAxiosError, createAxiosClient } from './axios-client';
 import { Result } from './types/result';
 import { OpenApiToTemplate } from './types/open-api-helper';
-import { z } from 'zod';
 import { RoutingConfigFilter } from './types/filters';
 
-const uuidSchema = z.uuidv4();
-
 export const httpClient = createAxiosClient();
 
 export const routingConfigurationApiClient = {
@@ -75,22 +71,10 @@ export const routingConfigurationApiClient = {
     token: string,
     id: RoutingConfig['id']
   ): Promise<Result<RoutingConfig>> {
-    if (!uuidSchema.safeParse(id).success) {
-      return {
-        error: {
-          errorMeta: {
-            code: ErrorCase.VALIDATION_FAILED,
-            description: 'Invalid routing configuration ID format',
-            details: { id },
-          },
-          actualError: undefined,
-        },
-      };
-    }
-
-    const url = `/v1/routing-configuration/${id}` satisfies OpenApiToTemplate<
-      GetV1RoutingConfigurationByRoutingConfigIdData['url']
-    >;
+    const url =
+      `/v1/routing-configuration/${encodeURIComponent(id)}` satisfies OpenApiToTemplate<
+        GetV1RoutingConfigurationByRoutingConfigIdData['url']
+      >;
 
     const { data, error } = await catchAxiosError(
       httpClient.get<RoutingConfigSuccess>(url, {