CCM-8590: rm letter from copy page

Author: alexnuttall

frontend/src/__tests__/components/forms/CopyTemplate/CopyTemplate.test.tsx

@@ -7,7 +7,6 @@ import { CopyTemplate } from '@forms/CopyTemplate/CopyTemplate';
 import {
   Template,
   TemplateFormState,
-  TemplateType,
 } from 'nhs-notify-web-template-management-utils';
 
 jest.mock('@utils/amplify-utils');
@@ -33,12 +32,7 @@ jest.mock('react', () => {
 
 describe('Choose template page', () => {
   it('selects one radio button at a time', () => {
-    const container = render(
-      <CopyTemplate
-        template={mockDeep<Template>()}
-        templateTypes={Object.values(TemplateType)}
-      />
-    );
+    const container = render(<CopyTemplate template={mockDeep<Template>()} />);
     expect(container.asFragment()).toMatchSnapshot();
 
     const radioButtons = [
@@ -85,12 +79,7 @@ describe('Choose template page', () => {
 
     jest.mocked(useActionState).mockImplementation(mockUseActionState);
 
-    const container = render(
-      <CopyTemplate
-        template={mockDeep<Template>()}
-        templateTypes={Object.values(TemplateType)}
-      />
-    );
+    const container = render(<CopyTemplate template={mockDeep<Template>()} />);
     expect(container.asFragment()).toMatchSnapshot();
   });
 });

frontend/src/__tests__/components/forms/CopyTemplate/__snapshots__/CopyTemplate.test.tsx.snap

@@ -164,25 +164,6 @@ exports[`Choose template page renders error component 1`] = `
                       Text message (SMS)
                     </label>
                   </div>
-                  <div
-                    class="nhsuk-radios__item"
-                  >
-                    <input
-                      class="nhsuk-radios__input"
-                      data-testid="LETTER-radio"
-                      id="templateType-LETTER"
-                      name="templateType"
-                      type="radio"
-                      value="LETTER"
-                    />
-                    <label
-                      class="nhsuk-label nhsuk-radios__label"
-                      for="templateType-LETTER"
-                      id="templateType-LETTER--label"
-                    >
-                      Letter
-                    </label>
-                  </div>
                 </div>
               </div>
             </fieldset>
@@ -342,25 +323,6 @@ exports[`Choose template page selects one radio button at a time 1`] = `
                       Text message (SMS)
                     </label>
                   </div>
-                  <div
-                    class="nhsuk-radios__item"
-                  >
-                    <input
-                      class="nhsuk-radios__input"
-                      data-testid="LETTER-radio"
-                      id="templateType-LETTER"
-                      name="templateType"
-                      type="radio"
-                      value="LETTER"
-                    />
-                    <label
-                      class="nhsuk-label nhsuk-radios__label"
-                      for="templateType-LETTER"
-                      id="templateType-LETTER--label"
-                    >
-                      Letter
-                    </label>
-                  </div>
                 </div>
               </div>
             </fieldset>

frontend/src/app/copy-template/[templateId]/page.tsx

@@ -2,11 +2,7 @@
 
 import { redirect, RedirectType } from 'next/navigation';
 import { CopyTemplate } from '@forms/CopyTemplate/CopyTemplate';
-import {
-  PageProps,
-  $Template,
-  TemplateType,
-} from 'nhs-notify-web-template-management-utils';
+import { PageProps, $Template } from 'nhs-notify-web-template-management-utils';
 import { getTemplate } from '@utils/form-actions';
 import { zodValidate } from '@utils/validate-template';
 
@@ -21,15 +17,7 @@ const CopyTemplatePage = async (props: PageProps) => {
     return redirect('/invalid-template', RedirectType.replace);
   }
 
-  const templateTypes = Object.values(TemplateType).filter(
-    (t) =>
-      process.env.NEXT_PUBLIC_ENABLE_LETTERS === 'true' ||
-      t !== TemplateType.LETTER
-  );
-
-  return (
-    <CopyTemplate template={validatedTemplate} templateTypes={templateTypes} />
-  );
+  return <CopyTemplate template={validatedTemplate} />;
 };
 
 export default CopyTemplatePage;

frontend/src/components/forms/CopyTemplate/CopyTemplate.tsx

@@ -16,13 +16,16 @@ import { copyTemplateAction } from './server-action';
 
 type CopyTemplate = {
   template: Template;
-  templateTypes: TemplateType[];
 };
 
 export const CopyTemplate = ({ template }: CopyTemplate) => {
   const [state, action] = useActionState(copyTemplateAction, { template });
 
-  const options = templateTypes.map((templateType) => ({
+  const options = [
+    TemplateType.NHS_APP,
+    TemplateType.EMAIL,
+    TemplateType.SMS,
+  ].map((templateType) => ({
     id: templateType,
     text: templateTypeDisplayMappings(templateType),
   }));

frontend/src/utils/constants.ts

@@ -1,2 +1,10 @@
+import { TemplateType } from 'nhs-notify-backend-client';
+
 export const MAX_SMS_CHARACTER_LENGTH = 918 as const;
 export const MAX_EMAIL_CHARACTER_LENGTH = 100_000 as const;
+
+export enum TemplateTypeDigital {
+  NHS_APP = TemplateType.NHS_APP,
+  SMS = TemplateType.SMS,
+  EMAIL = TemplateType.EMAIL,
+}

tests/test-team/template-mgmt-component-tests/template-mgmt-copy-page.component.spec.ts

@@ -96,7 +96,7 @@ test.describe('Copy Template Page', () => {
 
     await copyTemplatePage.loadPage(templates.email.id);
 
-    await expect(copyTemplatePage.radioButtons).toHaveCount(4);
+    await expect(copyTemplatePage.radioButtons).toHaveCount(3);
   });
 
   test('should display error if no template type option selected and continue button clicked', async ({