CCM-8590: check for literal true

Author: alexnuttall

frontend/src/__tests__/app/choose-a-template-type/page.test.tsx

@@ -37,7 +37,7 @@ test('ChooseATemplateTypePage', async () => {
 });
 
 test('ChooseATemplateTypePage - LETTER option is hidden when feature flag is not enabled', async () => {
-  delete process.env.NEXT_PUBLIC_ENABLE_LETTERS;
+  process.env.NEXT_PUBLIC_ENABLE_LETTERS = 'false';
 
   const page = await ChooseATemplateTypePage();
 

frontend/src/__tests__/app/copy-template/page.test.tsx

@@ -50,7 +50,7 @@ describe('CopyTemplatePage', () => {
   });
 
   it('Letter option is hidden when the feature flag is not enabled', async () => {
-    delete process.env.NEXT_PUBLIC_ENABLE_LETTERS;
+    process.env.NEXT_PUBLIC_ENABLE_LETTERS = 'false';
 
     getTemplateMock.mockResolvedValueOnce(template);
 

frontend/src/__tests__/app/create-letter-template/page.test.tsx

@@ -13,7 +13,7 @@ describe('CreateLetterTemplatePage', () => {
   });
 
   it('returns 404 when letters feature flag is not enabled', async () => {
-    delete process.env.NEXT_PUBLIC_ENABLE_LETTERS;
+    process.env.NEXT_PUBLIC_ENABLE_LETTERS = 'false';
 
     await expect(CreateLetterTemplatePage()).rejects.toThrow('NEXT_NOT_FOUND');
   });

frontend/src/app/choose-a-template-type/page.tsx

@@ -5,7 +5,9 @@ import { TemplateType } from 'nhs-notify-backend-client';
 
 const ChooseATemplateTypePage = async () => {
   const templateTypes = Object.values(TemplateType).filter(
-    (t) => process.env.NEXT_PUBLIC_ENABLE_LETTERS || t !== TemplateType.LETTER
+    (t) =>
+      process.env.NEXT_PUBLIC_ENABLE_LETTERS === 'true' ||
+      t !== TemplateType.LETTER
   );
 
   return <ChooseTemplate templateTypes={templateTypes} />;

frontend/src/app/copy-template/[templateId]/page.tsx

@@ -22,7 +22,9 @@ const CopyTemplatePage = async (props: PageProps) => {
   }
 
   const templateTypes = Object.values(TemplateType).filter(
-    (t) => process.env.NEXT_PUBLIC_ENABLE_LETTERS || t !== TemplateType.LETTER
+    (t) =>
+      process.env.NEXT_PUBLIC_ENABLE_LETTERS === 'true' ||
+      t !== TemplateType.LETTER
   );
 
   return (

frontend/src/app/create-letter-template/page.tsx

@@ -2,7 +2,7 @@ import { NHSNotifyMain } from '@atoms/NHSNotifyMain/NHSNotifyMain';
 import { notFound } from 'next/navigation';
 
 const CreateLetterTemplatePage = async () => {
-  if (!process.env.NEXT_PUBLIC_ENABLE_LETTERS) notFound();
+  if (process.env.NEXT_PUBLIC_ENABLE_LETTERS !== 'true') notFound();
 
   return (
     <NHSNotifyMain>