typos

Author: alexnuttall

lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts

@@ -1539,7 +1539,7 @@ describe('templateClient', () => {
       expect(result).toEqual({
         error: {
           code: 403,
-          message: 'UserWithOptionalClient cannot request a proof',
+          message: 'User cannot request a proof',
         },
       });
     });
@@ -1813,7 +1813,7 @@ describe('templateClient', () => {
       expect(result).toEqual({
         error: {
           code: 403,
-          message: 'UserWithOptionalClient cannot request a proof',
+          message: 'User cannot request a proof',
         },
       });
     });

lambdas/backend-api/src/templates/app/template-client.ts

@@ -374,14 +374,11 @@ export class TemplateClient {
     if (!clientConfig?.features.proofing) {
       log.error({
         code: ErrorCase.FEATURE_DISABLED,
-        description: 'UserWithOptionalClient cannot request a proof',
+        description: 'User cannot request a proof',
         clientConfig,
       });
 
-      return failure(
-        ErrorCase.FEATURE_DISABLED,
-        'UserWithOptionalClient cannot request a proof'
-      );
+      return failure(ErrorCase.FEATURE_DISABLED, 'User cannot request a proof');
     }
 
     const proofRequestUpdateResult =

tests/test-team/template-mgmt-api-tests/request-proof.api.spec.ts

@@ -228,7 +228,7 @@ test.describe('POST /v1/template/:templateId/proof', () => {
     });
   });
 
-  test('returns 403 - user without a client cannot request a proof', async ({
+  test('returns 400 - user without a client cannot request a proof', async ({
     request,
   }) => {
     const templateId = randomUUID();
@@ -237,8 +237,8 @@ test.describe('POST /v1/template/:templateId/proof', () => {
     const template = {
       ...TemplateFactory.createLetterTemplate(
         templateId,
-        userProofingEnabled,
-        'userProofingEnabledtemplate',
+        userWithoutClient,
+        'userWithoutClientTemplate',
         // template should not reach this status if proofing is not
         // enabled for the client
         'PENDING_PROOF_REQUEST'

utils/utils/src/types.ts

@@ -137,13 +137,13 @@ export type ProofingRequest = {
   campaignId: string;
   language: Language;
   letterType: LetterType;
-  user: User;
   pdfVersionId: string;
   personalisationParameters: string[];
   supplier: string;
   templateId: string;
   templateName: string;
   testDataVersionId?: string;
+  user: User;
 };
 
 export type User = { userId: string; clientId: string };