CCM-10004: test stability

Author: mark-r-bjss

tests/test-team/pages/nhs-app/template-mgmt-create-nhs-app-page.ts

@@ -1,4 +1,4 @@
-import { Locator, Page } from '@playwright/test';
+import { expect, Locator, Page } from '@playwright/test';
 import { TemplateMgmtMessageFormatting } from '../template-mgmt-message-formatting';
 import { TemplateMgmtBasePageNonDynamic } from '../template-mgmt-base-page-non-dynamic';
 
@@ -47,4 +47,14 @@ export class TemplateMgmtCreateNhsAppPage extends TemplateMgmtBasePageNonDynamic
   async clickSaveAndPreviewButton() {
     await this.saveAndPreviewButton.click();
   }
+
+  async loadPage() {
+    await super.loadPage();
+    await this.waitForPageToLoad();
+  }
+
+  async waitForPageToLoad() {
+    const characterCountLocator = this.page.locator('[id="character-count-0"]');
+    await expect(characterCountLocator).toBeVisible();
+  }
 }

tests/test-team/pages/nhs-app/template-mgmt-edit-nhs-app-page.ts

@@ -1,4 +1,4 @@
-import { Locator, Page } from '@playwright/test';
+import { Locator, Page, expect } from '@playwright/test';
 import { TemplateMgmtMessageFormatting } from '../template-mgmt-message-formatting';
 import { TemplateMgmtBasePageDynamic } from '../template-mgmt-base-page-dynamic';
 
@@ -43,4 +43,14 @@ export class TemplateMgmtEditNhsAppPage extends TemplateMgmtBasePageDynamic {
   async clickSaveAndPreviewButton() {
     await this.saveAndPreviewButton.click();
   }
+
+  async loadPage(templateId: string) {
+    await super.loadPage(templateId);
+    await this.waitForPageToLoad();
+  }
+
+  async waitForPageToLoad() {
+    const characterCountLocator = this.page.locator('[id="character-count-0"]');
+    await expect(characterCountLocator).toBeVisible();
+  }
 }

tests/test-team/pages/sms/template-mgmt-create-sms-page.ts

@@ -1,4 +1,4 @@
-import { Locator, Page } from '@playwright/test';
+import { expect, Locator, Page } from '@playwright/test';
 import { TemplateMgmtMessageFormatting } from '../template-mgmt-message-formatting';
 import { TemplateMgmtBasePageNonDynamic } from '../template-mgmt-base-page-non-dynamic';
 
@@ -53,6 +53,16 @@ export class TemplateMgmtCreateSmsPage extends TemplateMgmtBasePageNonDynamic {
     );
   }
 
+  async loadPage() {
+    await super.loadPage();
+    await this.waitForPageToLoad();
+  }
+
+  async waitForPageToLoad() {
+    const characterCountLocator = this.page.locator('[data-testid="character-message-count-0"]');
+    await expect(characterCountLocator).toBeVisible();
+  }
+
   async clickSaveAndPreviewButton() {
     await this.saveAndPreviewButton.click();
   }

tests/test-team/pages/sms/template-mgmt-edit-sms-page.ts

@@ -1,4 +1,4 @@
-import { Locator, Page } from '@playwright/test';
+import { expect, Locator, Page } from '@playwright/test';
 import { TemplateMgmtMessageFormatting } from '../template-mgmt-message-formatting';
 import { TemplateMgmtBasePageDynamic } from '../template-mgmt-base-page-dynamic';
 
@@ -48,6 +48,18 @@ export class TemplateMgmtEditSmsPage extends TemplateMgmtBasePageDynamic {
     );
   }
 
+  async loadPage(templateId: string) {
+    await super.loadPage(templateId);
+    await this.waitForPageToLoad();
+  }
+
+  async waitForPageToLoad() {
+    const characterCountLocator = this.page.locator(
+      '[data-testid="character-message-count-0"]'
+    );
+    await expect(characterCountLocator).toBeVisible();
+  }
+
   async clickSaveAndPreviewButton() {
     await this.saveAndPreviewButton.click();
   }

tests/test-team/template-mgmt-component-tests/nhs-app/template-mgmt-edit-nhs-app-template-page.component.spec.ts

@@ -273,6 +273,7 @@ test.describe('Edit NHS App Template Page', () => {
     }) => {
       const editTemplatePage = new TemplateMgmtEditNhsAppPage(page);
       await editTemplatePage.loadPage('valid-nhs-app-template');
+      await editTemplatePage.waitForPageToLoad();
       const newTabPromise = page.waitForEvent('popup');
       await page.getByRole('link', { name }).click();
       const newTab = await newTabPromise;