CCM-10387: add api test for proof request shared ownership

Author: alexnuttall

lambdas/backend-api/src/__tests__/templates/api/process-proof.test.ts

@@ -77,47 +77,3 @@ test.each([
     );
   }
 );
-
-test('sets virus scan status for a user-owned template', async () => {
-  const templateRepository = mockDeep<TemplateRepository>({
-    getOwner: jest
-      .fn()
-      .mockReturnValue({ owner: 'user-template-owner', clientOwned: false }),
-  });
-  const letterFileRepository = mockDeep<LetterFileRepository>();
-
-  const handler = createHandler({
-    templateRepository,
-    letterFileRepository,
-    logger: mockDeep<Logger>(),
-  });
-
-  await handler({
-    detail: {
-      s3ObjectDetails: {
-        objectKey: 'proofs/supplier/template-id/proof.pdf',
-        versionId: 'version-id',
-      },
-      scanResultDetails: { scanResultStatus: 'NO_THREATS_FOUND' },
-    },
-  });
-
-  expect(templateRepository.getOwner).toHaveBeenCalledWith('template-id');
-
-  expect(
-    letterFileRepository.copyFromQuarantineToInternal
-  ).toHaveBeenCalledWith(
-    'proofs/supplier/template-id/proof.pdf',
-    'version-id',
-    'proofs/user-template-owner/template-id/proof.pdf'
-  );
-
-  expect(
-    templateRepository.setLetterFileVirusScanStatusForProof
-  ).toHaveBeenCalledWith(
-    { owner: 'user-template-owner', id: 'template-id', clientOwned: false },
-    'proof.pdf',
-    'PASSED',
-    'supplier'
-  );
-});

lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts

@@ -1890,8 +1890,7 @@ describe('templateClient', () => {
         'en',
         pdfVersionId,
         undefined,
-        defaultLetterSupplier,
-        false
+        defaultLetterSupplier
       );
 
       expect(result).toEqual({
@@ -1966,8 +1965,7 @@ describe('templateClient', () => {
         'en',
         pdfVersionId,
         undefined,
-        defaultLetterSupplier,
-        false
+        defaultLetterSupplier
       );
 
       expect(result).toEqual({

lambdas/backend-api/src/templates/api/process-proof.ts

@@ -25,8 +25,7 @@ export const createHandler =
     const { templateId, fileName, supplier } =
       LetterProofRepository.parseQuarantineKey(objectKey);
 
-    const { owner, clientOwned } =
-      await templateRepository.getOwner(templateId);
+    const { owner } = await templateRepository.getOwner(templateId);
 
     const internalKey = LetterProofRepository.getInternalKey(
       owner,
@@ -63,7 +62,7 @@ export const createHandler =
     }
 
     await templateRepository.setLetterFileVirusScanStatusForProof(
-      { owner, id: templateId, clientOwned },
+      { owner, id: templateId, clientOwned: true },
       fileName,
       virusScanResult,
       supplier

lambdas/backend-api/src/templates/app/template-client.ts

@@ -449,12 +449,9 @@ export class TemplateClient {
       language,
       letterType,
       name,
-      owner,
       personalisationParameters,
     } = proofLetterValidationResult.data;
 
-    const clientOwned = owner?.startsWith('CLIENT#') || false;
-
     const pdfVersionId = files.pdfTemplate.currentVersion;
     const testDataVersionId = files.testDataCsv?.currentVersion;
 
@@ -468,8 +465,7 @@ export class TemplateClient {
       language,
       pdfVersionId,
       testDataVersionId,
-      this.defaultLetterSupplier,
-      clientOwned
+      this.defaultLetterSupplier
     );
 
     if (sendQueueResult.error) {

lambdas/backend-api/src/templates/infra/proofing-queue.ts

@@ -23,16 +23,14 @@ export class ProofingQueue {
     language: Language,
     pdfVersionId: string,
     testDataVersionId: string | undefined,
-    supplier: string,
-    clientOwned: boolean
+    supplier: string
   ) {
     try {
       const response = await this.sqsClient.send(
         new SendMessageCommand({
           QueueUrl: this.queueUrl,
           MessageBody: JSON.stringify({
             campaignId,
-            clientOwned,
             language,
             letterType,
             pdfVersionId,