Skip to content

CCM-7465: implement backend api PT.2#260

Merged
bhansell1 merged 49 commits intomainfrom
feature/CCM-7465_backend-api
Jan 21, 2025
Merged

CCM-7465: implement backend api PT.2#260
bhansell1 merged 49 commits intomainfrom
feature/CCM-7465_backend-api

Conversation

@bhansell1
Copy link
Contributor

@bhansell1 bhansell1 commented Jan 13, 2025 •
edited
Loading

Description

I closed the previous PR since it had over 200 items in the conversation. I've copied over the questions.

  • replaces amplify backend with our own backend-api

PT.3 will remove amplify entirely.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@bhansell1
CCM-7465: implement backend api and update automated tests
583b521
@bhansell1
CCM-7465: update automated tests to check for logout link
d99ed4f
@bhansell1
CCM-7465: add the auth pages when in CI for automated tests
9cb6154
@bhansell1
CCM-7465: don't build the backend
8ce2733
@bhansell1
CCM-7465: don't deploy backend resources
0c9b889
@bhansell1
CCM-7465: don't deploy backend resources
6b8eeb2
@bhansell1
CCM-7465: don't deploy backend resources
73544b6
@bhansell1
CCM-7465: don't deploy backend resources
6be7690
@bhansell1
CCM-7465: don't deploy backend resources
223bc6a
@bhansell1
CCM-7465: don't deploy backend resources
c4c5cf3
@bhansell1
CCM-7465: add protected routes
861937c
@bhansell1
CCM-7465: add middleware
cab3b5b
@bhansell1
CCM-7465: temporarily redirect back home
428cb83
@bhansell1
CCM-7465: temporarily redirect back home
bbedfe9
@bhansell1
CCM-7465: set env vars required for amplify and next app
620f193
@bhansell1
CCM-7465: disable route protection
04cf3e6 
debug

add outputs

debug

debug

debug

debug

debug

debug

CCM-7465: create amplify_ouputs..json file instread of using process.env

CCM-7465: move .env

debug

debug

debug

debug

debug

debug

debug

debug

debug

debug

debug

debug
@bhansell1
CCM-7465: change from bash to JS version of creating amplify outputs
7cb6bb9
@bhansell1
CCM-7465: create a .env file for the CI tests
3fb681c
@bhansell1
CCM-7465: clean up unused files
340e3ad
@bhansell1
Merge branch 'feature/CCM-7465_use-jwt-sub' of https://github.com/NHS…
5b57282 
…Digital/nhs-notify-web-template-management into feature/CCM-7465_use_backend-api
@bhansell1
CCM-7465: re-add protected routes
5362455
@bhansell1
CCM-7465: add stdout logs to paywright for debugging
86eb40f
@bhansell1
CCM-7465: add a 2 minute timeout for webserver load while debugging
050dfe2
@bhansell1
CCM-7465: remove authorization caching. Which is causing tests to fail
49927ff
@bhansell1
CCM-7465: set retries to 3 to see if a retry helps with the tests.
4c5abd4
@bhansell1
CCM-7465: fix automated test by creating a new page when asserting ba…
61bd097 
…ck links
@bhansell1
CCM-7465: update docs with tips. Fix linting and unit tests
e3f8699
@bhansell1
CCM-7465: pull meta from amplify_outputs in automated tests
1a83326
@bhansell1
CCM-7465: re-add redirect location when not signed in
bb724ad
@bhansell1
CCM-7465: update token check in form-actions
5a5ec5a
gparry333
gparry333 previously approved these changes Jan 14, 2025
View reviewed changes
gparry333
gparry333 previously approved these changes Jan 16, 2025
View reviewed changes
harrim91
harrim91 previously approved these changes Jan 16, 2025
View reviewed changes
m-salaudeen
m-salaudeen previously approved these changes Jan 17, 2025
View reviewed changes
@bhansell1 bhansell1 dismissed stale reviews from m-salaudeen, chris-elliott-nhsd, harrim91, and gparry333 January 20, 2025 16:49

The merge-base changed after approval.

@bhansell1 bhansell1 merged commit cd180a5 into main Jan 21, 2025
26 checks passed
@bhansell1 bhansell1 deleted the feature/CCM-7465_backend-api branch January 21, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harrim91 harrim91 harrim91 approved these changes

@gparry333 gparry333 gparry333 approved these changes

@mark-r-bjss mark-r-bjss mark-r-bjss approved these changes

@chris-elliott-nhsd chris-elliott-nhsd chris-elliott-nhsd left review comments

@m-salaudeen m-salaudeen m-salaudeen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bhansell1 @harrim91 @gparry333 @chris-elliott-nhsd @mark-r-bjss @m-salaudeen