CCM-8744: force refresh access tokens in middleware#337
Merged
Conversation
chris-elliott-nhsd
approved these changes
Mar 13, 2025
bhansell1
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
origin_jticlaim for signing csrf tokens. This is linked to the refresh token and persists for the life of the refresh token so is a more stable session id. Fixing an existing bug where CSRF token would become invalid after the access token expired.This goes hand in hand with NHSDigital/nhs-notify-iam-webauth#193
The intention was to prevent concurrent logins, but that wasn't feasible with Cognito. The auth PR changes the signout process to do global signout. This PR forces the refresh token to be used on every request - if global signout has been invoked then trying to use the revoked refresh token will cause auth failure and the user will be signed out.
Context
Intention was to prevent users from having concurrent sessions - recommendation from pen test. But just tidying and fixing things here.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.