Skip to content

CCM-8955: upgrade secret scanner and ignore false positive#338

Merged
mark-r-bjss merged 4 commits intomainfrom
fix/CCM-8955_upgrade-secret-scanner
Mar 11, 2025
Merged

CCM-8955: upgrade secret scanner and ignore false positive#338
mark-r-bjss merged 4 commits intomainfrom
fix/CCM-8955_upgrade-secret-scanner

Conversation

@mark-r-bjss
Copy link
Contributor

@mark-r-bjss mark-r-bjss commented Mar 10, 2025

Description

Upgrade secrets scanner to 8.24.0.

Ignore commit b19d88d1d92b0530f065feefcf25d8cdd82a876a as this is a false positive because:

  • The tokens are test data for the dev environment
  • They relate to a transient user in a transient sandbox
  • They are expired

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

m-houston
m-houston previously approved these changes Mar 10, 2025
@mark-r-bjss mark-r-bjss enabled auto-merge (squash) March 11, 2025 08:18
@mark-r-bjss mark-r-bjss merged commit 0f0d94c into main Mar 11, 2025
29 checks passed
@mark-r-bjss mark-r-bjss deleted the fix/CCM-8955_upgrade-secret-scanner branch March 11, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants