Merged
Conversation
ClareJonesBJSS
force-pushed
the
feature/CCM-8579_generated-type-inheritance
branch
4 times, most recently
from
af20d58 to
938e9e9
Compare
ClareJonesBJSS
force-pushed
the
feature/CCM-8579_generated-type-inheritance
branch
2 times, most recently
from
7dff2a9 to
a727bdf
Compare
ClareJonesBJSS
force-pushed
the
feature/CCM-8579_generated-type-inheritance
branch
from
a727bdf to
9d4a431
Compare
…upload-pdf-backend-squash
ClareJonesBJSS
previously approved these changes
Mar 17, 2025
mark-r-bjss
reviewed
Mar 17, 2025
mark-r-bjss
previously approved these changes
Mar 17, 2025
gparry333
previously approved these changes
Mar 17, 2025
mark-r-bjss
approved these changes
Mar 19, 2025
bhansell1
approved these changes
Mar 19, 2025
gparry333
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a
POST -> /letter-templateendpoint to create letter templates.The template is first updated to
PENDING_UPLOAD, then one or both files are sent to s3, then the template is updated toPENDING_VALIDATION.Further downstream, we will have to wait and retry if the status hasn't reached
PENDING_VALIDATIONyet.Update endpoint has not been added, ticketed separately: https://nhsd-jira.digital.nhs.uk/browse/CCM-8993
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.