Skip to content

CCM-8994: Handle missing tfvars files #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chris-elliott-nhsd merged 3 commits into from
Mar 19, 2025
Merged

CCM-8994: Handle missing tfvars files #348

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75b6170
CCM-8994: Handle missing tfvars files
chris-elliott-nhsd Mar 12, 2025
5dd9a0e
Merge branch 'main' into feature/CCM-8994_handle-missing-tfvars
chris-elliott-nhsd Mar 14, 2025
1dd6103
Merge branch 'main' into feature/CCM-8994_handle-missing-tfvars
chris-elliott-nhsd Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions infrastructure/terraform/bin/terraform.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,24 +539,26 @@ fi;
[ -f "${dynamic_file_path}" ] && tf_var_file_paths+=("${dynamic_file_path}");

# Warn on duplication
duplicate_variables="$(cat "${tf_var_file_paths[@]}" | sed -n -e 's/\(^[a-zA-Z0-9_\-]\+\)\s*=.*$/\1/p' | sort | uniq -d)";
[ -n "${duplicate_variables}" ] \
&& echo -e "
###################################################################
# WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING #
###################################################################
The following input variables appear to be duplicated:
${duplicate_variables}
This could lead to unexpected behaviour. Overriding of variables
has previously been unpredictable and is not currently supported,
but it may work.
Recent changes to terraform might give you useful overriding and
map-merging functionality, please use with caution and report back
on your successes & failures.
###################################################################";
if [ ${#tf_var_file_paths[@]} -gt 0 ]; then
duplicate_variables="$(cat "${tf_var_file_paths[@]}" | sed -n -e 's/\(^[a-zA-Z0-9_\-]\+\)\s*=.*$/\1/p' | sort | uniq -d)";
[ -n "${duplicate_variables}" ] \
&& echo -e "
###################################################################
# WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING #
###################################################################
The following input variables appear to be duplicated:
${duplicate_variables}
This could lead to unexpected behaviour. Overriding of variables
has previously been unpredictable and is not currently supported,
but it may work.
Recent changes to terraform might give you useful overriding and
map-merging functionality, please use with caution and report back
on your successes & failures.
###################################################################";
fi

# Build up the tfvars arguments for terraform command line
for file_path in "${tf_var_file_paths[@]}"; do
Expand Down
Loading