Merged
Conversation
chris-elliott-nhsd
previously approved these changes
Mar 13, 2025
alexnuttall
previously approved these changes
Mar 14, 2025
harrim91
dismissed stale reviews from alexnuttall and chris-elliott-nhsd
via
0347b77
ClareJonesBJSS
previously approved these changes
Mar 14, 2025
bhansell1
reviewed
Mar 17, 2025
bhansell1
previously approved these changes
Mar 17, 2025
mark-r-bjss
approved these changes
Mar 18, 2025
alexnuttall
approved these changes
Mar 18, 2025
ClareJonesBJSS
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds internal and quarantine s3 buckets for virus-scan / validation process
Also re-works KMS key usage on sandbox environments. There is now an account level KMS that can be shared across all sandbox environments. This key is only created in the dev account (see https://github.com/NHSDigital/nhs-notify-internal/pull/238). The DynamoDB table and S3 buckets in sandbox environments use this shared key.
In regular environments, the s3 buckets use the
applevel kms key, and the DynamoDB tables use the inline DynamoDB key.It turns out that DynamoDB supports switching KMS keys without need to recreating a table, or for any manual data migration steps. https://aws.amazon.com/about-aws/whats-new/2019/02/amazon-dynamodb-adds-support-for-switching-encryption-keys-to-encrypt-your-data-at-rest/
Will create another ticket to switch the DynamoDB keys used in static environments.
Context
s3 buckets used by multiple processes. Adding basic buckets separately allows other tickets to progress in parallel.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.