Skip to content

CCM-9743: disable amplify auto disconnect#423

Merged
bhansell1 merged 2 commits intomainfrom
feature/CCM-9743_disable-auto-disconnect
Apr 17, 2025
Merged

CCM-9743: disable amplify auto disconnect#423
bhansell1 merged 2 commits intomainfrom
feature/CCM-9743_disable-auto-disconnect

Conversation

@bhansell1
Copy link
Copy Markdown
Contributor

@bhansell1 bhansell1 commented Apr 16, 2025

Description

  • disables Amplify's branch auto disconnect

Context

pr_close workflows are failing, this failure. Happens because we're explicitly stating we want to delete the branch, but it has already been deleted due to the auto disconnect policy.

We're favouring using TF resource remove_amplify_branch instead of Amplify's branch auto disconnect

Disabling auto branch disconnect will still clean up Amplify branches on PR close. The pr_destroy_dynamic_env.yaml workflow is triggered on PR closed which will perform a tf destroy, which calls remove_amplify_branch.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@bhansell1 bhansell1 merged commit 2118ec2 into main Apr 17, 2025
32 checks passed
@bhansell1 bhansell1 deleted the feature/CCM-9743_disable-auto-disconnect branch April 17, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants