Skip to content

CCM-8875 Support pending proof request status #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicki-nhs merged 18 commits into from
Apr 28, 2025
Merged

CCM-8875 Support pending proof request status #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d2f0398
init
alexnuttall Apr 17, 2025
28f4722
CCM-8588 Add unit test for template repository
nicki-nhs Apr 17, 2025
353032e
CCM-8588 CTA copy to request proof
nicki-nhs Apr 17, 2025
013fe03
CCM-8588 Add env var to enable proofing
nicki-nhs Apr 17, 2025
5108cfc
CCM-8588 Update terraform-docs
nicki-nhs Apr 22, 2025
10c50f8
CCM-8588 Update id of CTA on preview letter template
nicki-nhs Apr 22, 2025
83e55a3
CCM-8588 Update unit test
nicki-nhs Apr 23, 2025
eeca1ab
CCM-8588 Fix unit test
nicki-nhs Apr 23, 2025
7742d95
CCM-8588 Turn off proofing flag
nicki-nhs Apr 24, 2025
31956c3
Merge branch 'main' into feature/CCM-8588-templates-require-proof
nicki-nhs Apr 24, 2025
22edfca
CCM-8588 Update tf var
nicki-nhs Apr 24, 2025
7dffdba
Merge branch 'feature/CCM-8588-templates-require-proof' of https://gi…
nicki-nhs Apr 24, 2025
7dad8f2
Merge branch 'main' into feature/CCM-8588-templates-require-proof
nicki-nhs Apr 25, 2025
b5f86a6
CCM-8588 Add tag colour mapping for new status
nicki-nhs Apr 25, 2025
818c770
Merge branch 'feature/CCM-8588-templates-require-proof' of https://gi…
nicki-nhs Apr 25, 2025
e2cc2f6
CCM-8588 Update unit tests
nicki-nhs Apr 25, 2025
eda3dcb
CCM-8875 Update CTA id in test
nicki-nhs Apr 28, 2025
586df58
CCM-8875 Fix colour mapping on template list
nicki-nhs Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions frontend/src/__tests__/components/molecules/MessageTemplates.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,14 @@ describe('MessageTemplates component', () => {

expect(container.asFragment()).toMatchSnapshot();
});

it('matches snapshot with pending proof request status', () => {
messageTemplatesProps.templateList[0].templateStatus =
'PENDING_PROOF_REQUEST';
const container = render(<MessageTemplates {...messageTemplatesProps} />);

expect(container.asFragment()).toMatchSnapshot();
});
it('renders component correctly', () => {
render(<MessageTemplates {...messageTemplatesProps} />);

Expand Down
324 changes: 324 additions & 0 deletions frontend/src/__tests__/components/molecules/__snapshots__/MessageTemplates.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,330 @@ exports[`MessageTemplates component matches snapshot with not submitted status 1
</DocumentFragment>
`;

exports[`MessageTemplates component matches snapshot with pending proof request status 1`] = `
<DocumentFragment>
<div
class="nhsuk-grid-row"
>
<div
class="nhsuk-grid-column-full"
>
<table
class="nhsuk-table-responsive"
data-testid="manage-template-table"
id="manage-template-table"
>
<caption
class="nhsuk-table__caption"
>
List of templates
</caption>
<thead
class="nhsuk-table__head"
role="rowgroup"
>
<tr
class="nhsuk-table__row"
>
<th
class="nhsuk-table__header"
data-testid="manage-template-table-header-template-name"
scope="col"
>
Name
</th>
<th
class="nhsuk-table__header"
data-testid="manage-template-table-header-template-type"
scope="col"
>
Type
</th>
<th
class="nhsuk-table__header"
data-testid="manage-template-table-header-template-status"
scope="col"
>
Status
</th>
<th
class="nhsuk-table__header"
data-testid="manage-template-table-header-template-date-created"
scope="col"
>
Date created
</th>
<th
class="nhsuk-table__header"
data-testid="manage-template-table-header-action"
scope="col"
>
Action
</th>
</tr>
</thead>
<tbody
class="nhsuk-table__body"
>
<tr
class="nhsuk-table__row"
>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Name
</span>
<a
href="/preview-nhs-app-template/1"
>
Template 1
</a>
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Type
</span>
NHS App message
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Status
</span>
<strong
class="nhsuk-tag nhsuk-tag--blue"
>
Files uploaded
</strong>
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Date created
</span>
1st Jan 2021
<br />
00:00
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Action
</span>
<div
class="actionLinksWrapper"
>
<p
class="nhsuk-u-margin-bottom-2"
>
<a
aria-label="Copy Template 1"
href="/copy-template/1"
id="copy-template-link-0"
>
Copy
</a>
</p>
</div>
</td>
</tr>
<tr
class="nhsuk-table__row"
>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Name
</span>
<a
href="/preview-submitted-nhs-app-template/2"
>
Template 2
</a>
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Type
</span>
NHS App message
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Status
</span>
<strong
class="nhsuk-tag nhsuk-tag--grey"
>
Submitted
</strong>
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Date created
</span>
1st Feb 2021
<br />
00:00
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Action
</span>
<div
class="actionLinksWrapper"
>
<p
class="nhsuk-u-margin-bottom-2"
>
<a
aria-label="Copy Template 2"
href="/copy-template/2"
id="copy-template-link-1"
>
Copy
</a>
</p>
</div>
</td>
</tr>
<tr
class="nhsuk-table__row"
>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Name
</span>
<a
href="/preview-submitted-letter-template/3"
>
Template 3
</a>
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Type
</span>
Standard letter - French
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Status
</span>
<strong
class="nhsuk-tag nhsuk-tag--grey"
>
Submitted
</strong>
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Date created
</span>
1st Feb 2021
<br />
00:00
</td>
<td
class="nhsuk-table__cell"
role="cell"
>
<span
aria-hidden="true"
class="nhsuk-table-responsive__heading"
>
Action
</span>
<div
class="actionLinksWrapper"
/>
</td>
</tr>
</tbody>
</table>
</div>
</div>
</DocumentFragment>
`;

exports[`MessageTemplates component matches snapshot with submitted status 1`] = `
<DocumentFragment>
<div
Expand Down
26 changes: 26 additions & 0 deletions frontend/src/__tests__/components/organisms/PreviewLetterTemplate.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,30 @@ describe('PreviewLetterTemplate component', () => {

expect(container.asFragment()).toMatchSnapshot();
});

it('matches snapshot when template status is PENDING_PROOF_REQUEST', () => {
const container = render(
<PreviewLetterTemplate
template={{
id: '53525D03-1BC1-4563-ABF9-A74FF04142AF',
name: 'letter',
templateType: 'LETTER',
templateStatus: 'PENDING_PROOF_REQUEST',
letterType: 'q4',
language: 'ar',
files: {
pdfTemplate: {
fileName: 'file.pdf',
currentVersion: 'a',
virusScanStatus: 'PASSED',
},
},
createdAt: '2025-04-02T09:33:25.729Z',
updatedAt: '2025-04-02T09:33:25.729Z',
}}
/>
);

expect(container.asFragment()).toMatchSnapshot();
});
});
Loading
Loading