CCM-7943: Add personalisationParameters#602
Closed
chris-elliott-nhsd wants to merge 2 commits intomainfrom
Closed
Conversation
chris-elliott-nhsd
force-pushed
the
feature/CCM-7943_add-personalisation-parameters
branch
from
03a6aee to
aa98c93
Compare
alexnuttall
reviewed
Jul 31, 2025
lambdas/event-publisher/src/domain/individual-event-schemas/common-template-schemas.ts
Outdated
Show resolved
Hide resolved
alexnuttall
previously approved these changes
Jul 31, 2025
bhansell1
previously approved these changes
Jul 31, 2025
harrim91
reviewed
Jul 31, 2025
Contributor
harrim91
left a comment
harrim91
left a comment
There was a problem hiding this comment.
This looks good. Would you mind making one other change I noticed? The value of plane should be data not control.
harrim91
previously approved these changes
Aug 4, 2025
chris-elliott-nhsd
dismissed stale reviews from harrim91, bhansell1, and alexnuttall
via
49ba498
chris-elliott-nhsd
force-pushed
the
feature/CCM-7943_add-personalisation-parameters
branch
from
49ba498 to
d910a05
Compare
alexnuttall
approved these changes
Aug 5, 2025
harrim91
reviewed
Aug 5, 2025
| dataschema: | ||
| 'https://notify.nhs.uk/events/schemas/template-deleted/v1.json', | ||
| dataschemaversion: '1.0.0', | ||
| dataschemaversion: '1.1.0', |
Contributor
There was a problem hiding this comment.
Wondering if this should stay at 1.0.0 for now, since we're not actually publishing a schema yet.
bhansell1
approved these changes
Aug 6, 2025
Contributor
Author
|
this is being absorbed by #610 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.