Skip to content

CCM-10630: Give error summary focus on appearance & adjust letter errors#615

Merged
ClareJonesBJSS merged 2 commits intomainfrom
feature/CCM-10630_error-focus
Aug 11, 2025
Merged

CCM-10630: Give error summary focus on appearance & adjust letter errors#615
ClareJonesBJSS merged 2 commits intomainfrom
feature/CCM-10630_error-focus

Conversation

@ClareJonesBJSS
Copy link
Contributor

@ClareJonesBJSS ClareJonesBJSS commented Aug 7, 2025

Description

  • Added focus behaviour to ZodErrorSummary and renamed to encourage universal use.
  • Removed errorHeading variable as according to guidance it should always be 'There is a problem'
  • Switched deprecated <zodError>.flatten() calls to z.flattenError(<zodError>)
  • Replaced ErrorMessage use for messages not tied to a specific field, to eliminate unwanted hidden 'Error: ' and correctly nest in <li>s

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@ClareJonesBJSS ClareJonesBJSS requested a review from a team as a code owner August 7, 2025 12:50
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-10630_error-focus branch from 02bf6be to f052e00 Compare August 7, 2025 13:27
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-10630_error-focus branch 2 times, most recently from b6fcf9c to 5e1fc43 Compare August 7, 2025 15:53
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-10630_error-focus branch from 5e1fc43 to 5afdaad Compare August 8, 2025 08:20
nicki-nhs
nicki-nhs previously approved these changes Aug 8, 2025
@ClareJonesBJSS ClareJonesBJSS merged commit 8cfb1ac into main Aug 11, 2025
28 checks passed
@ClareJonesBJSS ClareJonesBJSS deleted the feature/CCM-10630_error-focus branch August 11, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants