Skip to content

CCM-11027: enforce correct versioning of event schemas#624

Merged
chris-elliott-nhsd merged 4 commits intomainfrom
feature/CCM-11027_enforce-correct-versioning
Aug 21, 2025
Merged

CCM-11027: enforce correct versioning of event schemas#624
chris-elliott-nhsd merged 4 commits intomainfrom
feature/CCM-11027_enforce-correct-versioning

Conversation

@harrim91
Copy link
Contributor

Description

Adds CI checks to ensure that the event schema package has been versioned correctly when changes are made, and that schemas have been regenerated if required.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@harrim91 harrim91 requested review from a team as code owners August 11, 2025 11:45
@harrim91 harrim91 changed the base branch from main to feature/CCM-11026_publish-event-schemas August 11, 2025 11:46
alexnuttall
alexnuttall previously approved these changes Aug 11, 2025
ClareJonesBJSS
ClareJonesBJSS previously approved these changes Aug 11, 2025
@chris-elliott-nhsd chris-elliott-nhsd force-pushed the feature/CCM-11027_enforce-correct-versioning branch from 61fb0de to 8e3c470 Compare August 20, 2025 11:04
@chris-elliott-nhsd chris-elliott-nhsd requested a review from a team as a code owner August 20, 2025 11:04
@chris-elliott-nhsd chris-elliott-nhsd changed the base branch from feature/CCM-11026_publish-event-schemas to main August 20, 2025 11:05
@chris-elliott-nhsd chris-elliott-nhsd dismissed stale reviews from ClareJonesBJSS, alexnuttall, and themself August 20, 2025 11:05

The base branch was changed.

@chris-elliott-nhsd chris-elliott-nhsd force-pushed the feature/CCM-11027_enforce-correct-versioning branch from 278c43f to 8dd5fca Compare August 20, 2025 12:26
ClareJonesBJSS
ClareJonesBJSS previously approved these changes Aug 20, 2025
alexnuttall
alexnuttall previously approved these changes Aug 20, 2025
@chris-elliott-nhsd chris-elliott-nhsd merged commit 1660e6a into main Aug 21, 2025
55 of 56 checks passed
@chris-elliott-nhsd chris-elliott-nhsd deleted the feature/CCM-11027_enforce-correct-versioning branch August 21, 2025 11:41
bhansell1 pushed a commit that referenced this pull request Sep 4, 2025
Co-authored-by: Chris Elliott <chris.elliott17@nhs.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants