Skip to content

CCM-10422: download authorizer works with client ownership#626

Merged
alexnuttall merged 118 commits intomainfrom
feature/CCM-10422-download-auth-client-owner
Aug 19, 2025
Merged

CCM-10422: download authorizer works with client ownership#626
alexnuttall merged 118 commits intomainfrom
feature/CCM-10422-download-auth-client-owner

Conversation

@alexnuttall
Copy link
Contributor

@alexnuttall alexnuttall commented Aug 11, 2025

Description

Downloads are authorised if the owner segment in the URL matches notify client ID from Cognito.

Also blocks downloads for users with no client assigned. Proofing is already blocked if this is the case, so there is no functional difference.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@alexnuttall alexnuttall requested review from a team as code owners August 11, 2025 12:26
@alexnuttall alexnuttall changed the base branch from main to feature/CCM-10387-multi-user-update August 11, 2025 12:26
harrim91
harrim91 previously approved these changes Aug 11, 2025
@alexnuttall alexnuttall force-pushed the feature/CCM-10387-multi-user-update branch from 2c5790c to 251efa6 Compare August 12, 2025 10:32
@alexnuttall alexnuttall force-pushed the feature/CCM-10387-multi-user-update branch from cca3022 to 991edca Compare August 14, 2025 14:00
Base automatically changed from feature/CCM-10387-multi-user-update to main August 19, 2025 13:52
@alexnuttall alexnuttall dismissed stale reviews from chris-elliott-nhsd and harrim91 August 19, 2025 13:52

The base branch was changed.

@alexnuttall alexnuttall removed the request for review from a team August 19, 2025 15:15
@alexnuttall alexnuttall merged commit dcc1870 into main Aug 19, 2025
68 of 72 checks passed
@alexnuttall alexnuttall deleted the feature/CCM-10422-download-auth-client-owner branch August 19, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants