Conversation
…emplate-management into feature/CCM-10893-header-with-account-info
…emplate-management into feature/CCM-10893-header-with-account-info
…emplate-management into feature/CCM-10893-header-with-account-info
…emplate-management into feature/CCM-10893-account-header
…emplate-management into feature/CCM-10893-account-header
| z.object({ | ||
| proofing: z.boolean(), | ||
| // TODO: CCM-11148 Make routing required | ||
| routing: z.boolean().optional(), |
There was a problem hiding this comment.
why do we want to make it required? won't that mean we have to organise a big unnecessary migration of all our existing clients?
There was a problem hiding this comment.
I was making an assumption purely on the basis that proofing was required, but we can absolutely leave it as optional if thats the preferred approach!
| ); | ||
|
|
||
| const givenName = faker.person.firstName(); | ||
| const familyName = faker.person.lastName(); |
There was a problem hiding this comment.
what's the advantage of using faker here? don't we want deterministic tests?
There was a problem hiding this comment.
we dont assert anything about the names in the accessibility tests so I dont think it matters, but I can remove if you want
| /** | ||
| * User8 has a client with no client name set | ||
| */ | ||
| User8: { |
There was a problem hiding this comment.
i think i heard a conversation in the office yesterday about whether we could get better names for these users and clients to make the code clearer - can we start with this user? UserWithoutClientName?
…emplate-management into feature/CCM-10893-account-header
…emplate-management into feature/CCM-10893-account-header
nicki-nhs
dismissed stale reviews from chris-elliott-nhsd and alexnuttall
via
841bcd9
3 participants
Description
nhs-frontendto pre-release 10^10.0.0-internal.3to bring in the new header with account from the design systemnhs-frontendnhs-frontendNotifyBackLinkcomponent which replacesBackLinkfromnhsuk-react-componentsdue to changes fromnhs-frontendAuthLinkto remove redundant wrappingdivtruncate- truncates strings and replaces excess characters with ellipsestoken-utils- for client side handling of jwt tokens, and addgetIdTokenClaimsfunctionamplify-utilstoidTokeningetSessionServertoken-utilswhere relevantHeaderWithAccountcomponent whichnhs-frontendroutingfeature is true infeaturesprop)HeaderinClientLayoutwith the newHeaderWithAccountroutingfeature flag intoClientFeaturestype (doesnt yet do anything)idin the tests withdata-testidand adding conditional for empty itemsContentRendererto account for the aboveFooterto remove redundant html containers and update to use latest classes etc fromnhs-frontendContext
Users need to see the name of the client displayed in the header so that they can see which client they are currently creating or updating resources for
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.