CCM-11029: provider-side contract tests#678
Merged
Conversation
chris-elliott-nhsd
previously approved these changes
Sep 16, 2025
aidenvaines-cgi
requested changes
Sep 16, 2025
infrastructure/terraform/components/acct/ssm_parameter_github_packages_read_pat.tf
Outdated
Show resolved
Hide resolved
aidenvaines-cgi
previously approved these changes
Sep 23, 2025
This reverts commit 2509d17.
timireland
reviewed
Sep 25, 2025
Contributor
timireland
left a comment
timireland
left a comment
There was a problem hiding this comment.
add make test-contract-provider to test target line 54?
aidenvaines-cgi
approved these changes
Sep 25, 2025
Contributor
aidenvaines-cgi
left a comment
aidenvaines-cgi
left a comment
There was a problem hiding this comment.
i think i follow most of the JS bits well enough, the rest looks good to me
alexnuttall
approved these changes
Sep 25, 2025
m-houston
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.