Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,15 @@ data "aws_iam_policy_document" "delete_routing_config_lambda_policy" {
var.kms_key_arn
]
}

statement {
sid = "AllowSSMParameterRead"
effect = "Allow"

actions = [
"ssm:GetParameter",
]

resources = [local.client_ssm_path_pattern]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,15 @@ data "aws_iam_policy_document" "submit_routing_config_lambda_policy" {
var.kms_key_arn
]
}

statement {
sid = "AllowSSMParameterRead"
effect = "Allow"

actions = [
"ssm:GetParameter",
]

resources = [local.client_ssm_path_pattern]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ describe('RoutingConfigClient', () => {
};

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: {}, campaignIds: [campaignId] },
data: { features: { routing: true }, campaignIds: [campaignId] },
});

mocks.routingConfigRepository.create.mockResolvedValueOnce({
Expand All @@ -298,9 +298,16 @@ describe('RoutingConfigClient', () => {
});
});

test('returns 400 error when input is invalid', async () => {
test('returns validation error when input is invalid', async () => {
const { client, mocks } = setup();

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: {
features: { routing: true },
campaignIds: [routingConfig.campaignId],
},
});

const result = await client.createRoutingConfig(
{ a: 1 } as unknown as CreateUpdateRoutingConfig,
user
Expand Down Expand Up @@ -356,7 +363,7 @@ describe('RoutingConfigClient', () => {
};

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: {}, campaignIds: ['campaign'] },
data: { features: { routing: true }, campaignIds: ['campaign'] },
});

mocks.routingConfigRepository.create.mockResolvedValueOnce({
Expand Down Expand Up @@ -420,6 +427,41 @@ describe('RoutingConfigClient', () => {
});
});

test('returns failure if routing feature is disabled for the client', async () => {
const { client, mocks } = setup();

const input: CreateUpdateRoutingConfig = {
name: 'rc',
campaignId: 'campaign',
cascade: [
{
cascadeGroups: ['standard'],
channel: 'SMS',
channelType: 'primary',
defaultTemplateId: 'sms',
},
],
cascadeGroupOverrides: [{ name: 'standard' }],
};

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: { routing: false }, campaignIds: ['campaign'] },
});

const result = await client.createRoutingConfig(input, user);

expect(mocks.routingConfigRepository.create).not.toHaveBeenCalled();

expect(result).toEqual({
error: {
errorMeta: {
code: 400,
description: 'Routing feature is disabled',
},
},
});
});

test('returns failure if campaignId is not allowed for the client', async () => {
const { client, mocks } = setup();

Expand All @@ -438,7 +480,10 @@ describe('RoutingConfigClient', () => {
};

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: {}, campaignIds: ['another campaign'] },
data: {
features: { routing: true },
campaignIds: ['another campaign'],
},
});

const result = await client.createRoutingConfig(input, user);
Expand All @@ -460,6 +505,10 @@ describe('RoutingConfigClient', () => {
test('returns completed routing config', async () => {
const { client, mocks } = setup();

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: { routing: true } },
});

const id = '2cb1c52d-befa-42f4-8628-06cfe63aa64d';

const completed: RoutingConfig = {
Expand All @@ -482,12 +531,37 @@ describe('RoutingConfigClient', () => {
data: completed,
});
});

test('returns failure if routing feature is disabled for the client', async () => {
const { client, mocks } = setup();

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: { routing: false } },
});

const result = await client.submitRoutingConfig('some-id', user);

expect(mocks.routingConfigRepository.submit).not.toHaveBeenCalled();

expect(result).toEqual({
error: {
errorMeta: {
code: 400,
description: 'Routing feature is disabled',
},
},
});
});
});

describe('deleteRoutingConfig', () => {
test('returns undefined after deleting routing config', async () => {
const { client, mocks } = setup();

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: { routing: true } },
});

const id = '2cb1c52d-befa-42f4-8628-06cfe63aa64d';

const deleted: RoutingConfig = {
Expand All @@ -514,6 +588,10 @@ describe('RoutingConfigClient', () => {
test('returns error response from repository', async () => {
const { client, mocks } = setup();

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: { routing: true } },
});

const id = '2cb1c52d-befa-42f4-8628-06cfe63aa64d';

const errorResponse = {
Expand All @@ -531,6 +609,27 @@ describe('RoutingConfigClient', () => {

expect(result).toEqual(errorResponse);
});

test('returns failure if routing feature is disabled for the client', async () => {
const { client, mocks } = setup();

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: { routing: false }, campaignIds: ['campaign'] },
});

const result = await client.deleteRoutingConfig('some-id', user);

expect(mocks.routingConfigRepository.delete).not.toHaveBeenCalled();

expect(result).toEqual({
error: {
errorMeta: {
code: 400,
description: 'Routing feature is disabled',
},
},
});
});
});

describe('updateRoutingConfig', () => {
Expand All @@ -550,7 +649,10 @@ describe('RoutingConfigClient', () => {
};

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: {}, campaignIds: [routingConfig.campaignId] },
data: {
features: { routing: true },
campaignIds: [routingConfig.campaignId],
},
});

mocks.routingConfigRepository.update.mockResolvedValueOnce({
Expand All @@ -576,6 +678,12 @@ describe('RoutingConfigClient', () => {

test('returns validation error when update is invalid', async () => {
const { client, mocks } = setup();
mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: {
features: { routing: true },
campaignIds: [routingConfig.campaignId],
},
});

const update: CreateUpdateRoutingConfig = {
campaignId: routingConfig.campaignId,
Expand Down Expand Up @@ -648,6 +756,41 @@ describe('RoutingConfigClient', () => {
});
});

test('returns failure if routing feature is disabled for the client', async () => {
const { client, mocks } = setup();

const update: CreateUpdateRoutingConfig = {
cascade: routingConfig.cascade,
cascadeGroupOverrides: routingConfig.cascadeGroupOverrides,
name: routingConfig.name,
campaignId: 'this campaign',
};

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: {
features: { routing: false },
campaignIds: ['this campaign'],
},
});

const result = await client.updateRoutingConfig(
routingConfig.id,
update,
user
);

expect(mocks.routingConfigRepository.update).not.toHaveBeenCalled();

expect(result).toEqual({
error: {
errorMeta: {
code: 400,
description: 'Routing feature is disabled',
},
},
});
});

test('returns failure if campaignId is not allowed for the client', async () => {
const { client, mocks } = setup();

Expand All @@ -659,7 +802,10 @@ describe('RoutingConfigClient', () => {
};

mocks.clientConfigRepository.get.mockResolvedValueOnce({
data: { features: {}, campaignIds: ['another campaign'] },
data: {
features: { routing: true },
campaignIds: ['another campaign'],
},
});

const result = await client.updateRoutingConfig(
Expand Down
Loading
Loading