CCM-9916: preload fonts with cross origin directive#742
Merged
Conversation
alexnuttall
previously approved these changes
Oct 24, 2025
alexnuttall
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
upgrade-insecure-requestsdirective from CSP when running on localhost, which prevents Safari from trying to upgrade http localhost requests to httpsContext
When opening notify.nhs.uk in Safari, the site failed to load fonts served from https://assets.nhs.uk.
The browser console showed:
The site’s HTML was being served with:
These headers enable cross-origin isolation. Under this policy, cross-origin assets must either:
cross-originorsame-site.Font fetches were happening from within a
@font-faceblock in thenhsuk-frontendcss. Safari was doing these fetches as no-CORS requests. The assets.nhs.uk server serves these fonts without a CORP header. So Safari was unable to load the fonts.Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.