Merged
Conversation
ralph-hawkins
approved these changes
Mar 7, 2025
Collaborator
ralph-hawkins
left a comment
ralph-hawkins
left a comment
There was a problem hiding this comment.
Looks good.
Can you increase the line-height for this change too please?
govuk-body is 1.25, but nhs.uk is 1.47368.
Collaborator
Author
Done. I’ve hacked this in for now - hopefully we can switch over to properly using NHS Frontend at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the font from GDS Transport to Frutiger, to match the typography guidance of the NHS design system.
(It was previously using GDS Transport as the site uses the govuk-eleventy-plugin which is based on the GOV.UK Design System.)
For the time being this just copies in the
@font-facedeclarations. An alternative would be to add thenhsuk-frontendpackage alongsidegovuk-frontend, but given that we’re not using any of the NHS classes at the moment, that seems unnecessary.Screenshots