Skip to content

Adding links to accessibility checklist Closes #282 #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding links to accessibility checklist Closes #282 #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bbdbaf
Adding links to accessibility checklist
nicksp1 Nov 28, 2022
5011615
Removing broken link
nicksp1 Nov 28, 2022
ad0cc3b
Fixing markup issues
nicksp1 Nov 28, 2022
d0d6356
Resolving markdown issue: new markdownlint version
nicksp1 Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .markdownlint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a subset of this config in scripts/markdown-check-format.sh. Is it possible to make sure this is defined only in one place?

"MD033": {
"allowed_elements": [
"br",
"a"
]
},
"MD013": false
}
2 changes: 1 addition & 1 deletion insights/review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ You may wish to score each individual component or system separately for these a
- Our automated checks focus on individual components and the contracts between them, not on testing the whole system together.
- We use stubs to insulate our tests from other components and systems — always for automated tests, sometimes for exploratory testing.
- We understand user needs and non-functional requirements and our tests prove they are being met.
- e.g. accessibility, browser compatibility, performance, capacity, resilience.
- e.g. [accessibility](https://nhsdigital.github.io/accessibility-checklist/), browser compatibility, performance, capacity, resilience.
- Our components have versioned APIs.
- Breaking changes are detected and clearly indicated.
- e.g. using Consumer-Driven Contract testing and semantic versioning.
Expand Down
2 changes: 1 addition & 1 deletion practices/continuous-integration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ A basic checklist of things to include in CI/CD. NB: This is not exhaustive, and
| Dead code detection | Do you perform static code analysis to look for dead code? What automated tools do you use? Does the tooling integrate directly into your IDE for instant feedback? |
| Complexity score | Do you perform static code analysis to look at function/file complexity? What automated tools do you use? Does the tooling integrate directly into your IDE for instant feedback? Are the results presented in such a way that acting on them is clear to you? |
| Security vulnerabilities | Do you scan for security vulnerabilities in your code? What automated tools do you use? Does the tooling integrate directly into your IDE for instant feedback? Are the results presented in such a way that acting on them is clear to you? |
| UI Accessibility testing | Do you check for accessibility issues? Are these fully automated as part of your pipeline? What automated tools do you use? Does the tooling integrate directly into your IDE for instant feedback? |
| UI Accessibility testing | Do you check for [accessibility](https://nhsdigital.github.io/accessibility-checklist/) issues? Are these fully automated as part of your pipeline? What automated tools do you use? Does the tooling integrate directly into your IDE for instant feedback? |
| HTML compliance | Do you check your UI code for HTML compliance? Are these fully automated as part of your pipeline? What automated tools do you use? Does the tooling integrate directly into your IDE for instant feedback? |
| FHIR compliance | Do you check your FHIR APIs for FHIR compliance? Are these fully automated as part of your pipeline? What automated tools do you use? Does the tooling integrate directly into your IDE for instant feedback? |
| Tech radar check | Have your frameworks and technologies been deprecated by NHSD? Do you currently check your application against the NHSD Tech Radar? If so, how? Does the tooling integrate directly into your IDE for instant feedback? |
Expand Down
Loading