Skip to content

VIA-831 LC flush hydrator log to capture final entry#606

Merged
liming-cheung-nhs merged 1 commit intomainfrom
via-831-flush-hydrator-logs
Mar 27, 2026
Merged

VIA-831 LC flush hydrator log to capture final entry#606
liming-cheung-nhs merged 1 commit intomainfrom
via-831-flush-hydrator-logs

Conversation

@liming-cheung-nhs
Copy link
Contributor

@liming-cheung-nhs liming-cheung-nhs commented Mar 27, 2026

Description

VIA-831

Hydrator was intermittently losing the final report log which indicates what content has changed and if there were any errors on the call to content API.

This attempts to fix it by flushing the logs in finally clause.

testing

Cannot test properly in dev workspace as nonprod content service is failing - tested the log flushing by taking out the call out to content as best attempt to get assurance - had it running every two minutes and was writing logs. Can push to preprod when appropriate and leave running to see how it goes on PR merge as best assurance.

Context

This will hopefully ensure we do catch changes in the contents and not miss changes.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@liming-cheung-nhs liming-cheung-nhs requested a review from a team as a code owner March 27, 2026 11:46
@liming-cheung-nhs liming-cheung-nhs marked this pull request as draft March 27, 2026 11:47
@liming-cheung-nhs liming-cheung-nhs marked this pull request as ready for review March 27, 2026 12:43
@liming-cheung-nhs liming-cheung-nhs merged commit a561b97 into main Mar 27, 2026
32 checks passed
@liming-cheung-nhs liming-cheung-nhs deleted the via-831-flush-hydrator-logs branch March 27, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants