Skip to content

Comments

NPA-3889: Expanded examples for the related person#138

Merged
kamran-iqbal4-NHSD merged 4 commits intomasterfrom
dev/NPA-3889-expanded-examples
Feb 5, 2025
Merged

NPA-3889: Expanded examples for the related person#138
kamran-iqbal4-NHSD merged 4 commits intomasterfrom
dev/NPA-3889-expanded-examples

Conversation

@kamran-iqbal4-NHSD
Copy link
Contributor

Pull Request Checklist

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-3889

Description/Change Summary

  • Expanded examples for related person to reflect postman collection

How to test?

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-3889

Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but ticket is missing And the sandbox returns that response when the correct inputs have been given AC

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-3889

Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kamran-iqbal4-NHSD kamran-iqbal4-NHSD merged commit b0852c8 into master Feb 5, 2025
9 checks passed
@kamran-iqbal4-NHSD kamran-iqbal4-NHSD deleted the dev/NPA-3889-expanded-examples branch February 5, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants