Skip to content

Comments

NPA-4421: Increase SpikeArrest Limit#145

Merged
JackPlowman merged 3 commits intomasterfrom
dev/NPA-4421_Increase_Spike_Limit
Feb 25, 2025
Merged

NPA-4421: Increase SpikeArrest Limit#145
JackPlowman merged 3 commits intomasterfrom
dev/NPA-4421_Increase_Spike_Limit

Conversation

@JackPlowman
Copy link
Contributor

@JackPlowman JackPlowman commented Feb 25, 2025

Pull Request

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-4421

Description/Change Summary

  • This change enforces the spike arrest to allow a max of 15 request per second.
  • So if the quota is 600 per minute. The requester can only hit the service a max of 15 times in any of the seconds within the minute. To stop a user taking all 600 requests in single second
  • From docs about spike arrest
 - intps (number of requests per second, smoothed into intervals of milliseconds)
 - intpm (number of requests per minute, smoothed into intervals of seconds)

How to test?

  • Will be tested with performance testing once merged in

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4421

@JackPlowman JackPlowman self-assigned this Feb 25, 2025
@JackPlowman JackPlowman added the enhancement New feature or request label Feb 25, 2025
@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4421

@JackPlowman JackPlowman force-pushed the dev/NPA-4421_Increase_Spike_Limit branch from fc7a489 to 31323a6 Compare February 25, 2025 11:59
@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4421

@JackPlowman JackPlowman marked this pull request as ready for review February 25, 2025 12:01
@JackPlowman JackPlowman changed the title NPA-4421: Increase Spike Limit NPA-4421: Increase SpikeArrest Limit Feb 25, 2025
@JackPlowman JackPlowman merged commit 69f6c38 into master Feb 25, 2025
13 checks passed
@JackPlowman JackPlowman deleted the dev/NPA-4421_Increase_Spike_Limit branch February 25, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants