Skip to content

NPA-5054 Add Prettier Commit Check#208

Merged
JackPlowman merged 3 commits intomasterfrom
dev/NPA-5063_Run_Prettier
May 29, 2025
Merged

NPA-5054 Add Prettier Commit Check#208
JackPlowman merged 3 commits intomasterfrom
dev/NPA-5063_Run_Prettier

Conversation

@JackPlowman
Copy link
Contributor

@JackPlowman JackPlowman commented May 29, 2025

Pull Request

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5054

Description/Change Summary

  • Run Prettier on all files not ignored
  • Added Prettier Commit Check

How to test?

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@JackPlowman JackPlowman self-assigned this May 29, 2025
@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5063

@JackPlowman JackPlowman changed the title NPA-5054 Run Prettier NPA-5054 Add Prettier Commit Checks May 29, 2025
@JackPlowman JackPlowman changed the title NPA-5054 Add Prettier Commit Checks NPA-5054 Add Prettier Commit Check May 29, 2025
@JackPlowman JackPlowman marked this pull request as ready for review May 29, 2025 13:22
@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5063

@JackPlowman JackPlowman force-pushed the dev/NPA-5063_Run_Prettier branch from bab72d7 to 4705531 Compare May 29, 2025 13:42
@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5063

@JackPlowman JackPlowman merged commit 24e1374 into master May 29, 2025
16 of 17 checks passed
@JackPlowman JackPlowman deleted the dev/NPA-5063_Run_Prettier branch May 29, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments