Skip to content

Comments

NPA-5137 Update Poetry Configuration#221

Merged
lelliott-hippo merged 1 commit intomasterfrom
NPA-5137-Update-public-repo-Poetry-configuration
Jun 12, 2025
Merged

NPA-5137 Update Poetry Configuration#221
lelliott-hippo merged 1 commit intomasterfrom
NPA-5137-Update-public-repo-Poetry-configuration

Conversation

@lelliott-hippo
Copy link
Contributor

Pull Request

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5137

Description/Change Summary

In pyproject.toml: [tools.poetry.dev-dependencies] -> [tools.poetry.group.dev.dependencies]

How to test?

  • Ran poetry install to create fresh Python virtual environment

  • make test in sandbox environment passed

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5137

Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JackPlowman JackPlowman changed the title NPA-5137 Update public repo Poetry configuration NPA-5137 Update Poetry Configuration Jun 12, 2025
@JackPlowman JackPlowman added the dependencies Pull requests that update a dependency file label Jun 12, 2025
@lelliott-hippo lelliott-hippo force-pushed the NPA-5137-Update-public-repo-Poetry-configuration branch from f83487f to 1d591e8 Compare June 12, 2025 13:44
@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5137

@lelliott-hippo lelliott-hippo merged commit b36b927 into master Jun 12, 2025
16 of 17 checks passed
@lelliott-hippo lelliott-hippo deleted the NPA-5137-Update-public-repo-Poetry-configuration branch June 12, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants