Skip to content

Comments

NPA-4572: Update GP emails for consent and comprehension changes#229

Closed
lelliott-hippo wants to merge 2 commits intomasterfrom
task/NPA-4572/Update-GP-emails
Closed

NPA-4572: Update GP emails for consent and comprehension changes#229
lelliott-hippo wants to merge 2 commits intomasterfrom
task/NPA-4572/Update-GP-emails

Conversation

@lelliott-hippo
Copy link
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-4572


📝 PR Title Format

Must follow format: NPA-XXXX: Short Description of the Change


📄 Description/Summary of Changes

  • Added new access levels (RECRD, COND, CONSULT, DOCS)
  • Removed contacting GP surgery (CNTCT)
  • Updated CODE descriptions
  • Updated examples
  • Updated Postman collection

🧪 Developer Testing Carried Out

  • Local Postman testing

🧪 Reviewer Testing Required


✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX-<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • The traceability matrix is updated
    with
    new tests or requirements
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@lelliott-hippo lelliott-hippo added python Pull requests that update Python code do not merge postman Changes to the postman collection endpoints labels Jun 30, 2025
@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4572

Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes as is. Before merging the Postman Collection should be updated to merge in any new changes between this review and approval to merge into master. As well a link to the updated postman collection is required on the specification

Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ClarksonAdam
Copy link
Contributor

Changes in this PR have been reworked into new PR #244 which has now been merged

@ClarksonAdam ClarksonAdam deleted the task/NPA-4572/Update-GP-emails branch August 28, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge endpoints postman Changes to the postman collection python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants