NPA-4572: Update GP emails for consent and comprehension changes#229
Closed
lelliott-hippo wants to merge 2 commits intomasterfrom
Closed
NPA-4572: Update GP emails for consent and comprehension changes#229lelliott-hippo wants to merge 2 commits intomasterfrom
lelliott-hippo wants to merge 2 commits intomasterfrom
Conversation
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-4572 |
JackPlowman
reviewed
Jul 1, 2025
Contributor
There was a problem hiding this comment.
Happy with the changes as is. Before merging the Postman Collection should be updated to merge in any new changes between this review and approval to merge into master. As well a link to the updated postman collection is required on the specification
Contributor
|
Changes in this PR have been reworked into new PR #244 which has now been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🧾 Ticket Link
https://nhsd-jira.digital.nhs.uk/browse/NPA-4572
📝 PR Title Format
Must follow format:
NPA-XXXX: Short Description of the Change📄 Description/Summary of Changes
🧪 Developer Testing Carried Out
🧪 Reviewer Testing Required
✅ Developer Checklist
NPA-XXXX: <short-description><type>/NPA-XXXX-<short-description>NPA-XXXX: <short-description>with
new tests or requirements
terraform,documentation) are added👀 Reviewer Checklist
🚀 Post-merge
After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.
This will run the tests within the collection to check that the sandbox is working as expected once deployed.