-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add teacher to respective class #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…d abstractions for students and professors
…rseUnit to CourseUnitClassesView
…ircle to match the rest
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (60%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1763 +/- ##
=======================================
Coverage 60% 60%
=======================================
Files 2 2
Lines 81 81
=======================================
Hits 48 48
Misses 33 33 🚀 New features to boost your workflow:
|
pedroafmonteiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It looks great and it appears to be working correctly. However, I noticed that the teachers only appear on course units that the user is currently attending, not on old course units. This is probably because when we are fetching the user's schedule, we are not giving a "period" parameter.
Closes #1713
Added respective professor(s) to the top of the students list in the classes page.
Review checklist
View Changes
Performance