Open
Conversation
Accounting for setups which won't use the scaled waveform feature
Author
|
@agomez08 I see you're the most recent merger here, could this be merged? we just upgraded to 2024 and I accidentally used the master branch of this repo, after a few hours of debugging I recalled all this old work to get this fixed for newer versions - both issues seem to still be present |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've modified the .lvproj and .xml for 2023 - dropping support for PharLap, VxWorks and Linux32 as these seem to not work in LabVIEW 2023, it just crashes. I followed this article for the first commit:
https://knowledge.ni.com/KnowledgeArticleDetails?id=kA03q000001Dzz8CAC&l=en-GB
The second stage of modifications is that this never works if you don't have Scaled Waveform enabled. It uses auto-indexing in for loops where if Scaled Waveform is an empty array it will never compile correctly nor read actual waveform data so I've separated those out where I could and now can run the device with only single point enabled which was my intended use of this custom device - I think that would be similar for many so don't know why this hasn't been caught sooner?