Merged
Conversation
scarlehoff
force-pushed
the
merge_workflows
branch
2 times, most recently
from
b40f623 to
f158d7f
Compare
scarlehoff
force-pushed
the
merge_workflows
branch
from
f158d7f to
bcca428
Compare
RoyStegeman
approved these changes
Mar 14, 2025
Member
There was a problem hiding this comment.
I would appreciate it a lot if (many) more inline comments were placed to explain why keys are given the values that they have. While
run: |
pytest extra_tests/regression_checks.py
is pretty straightforward, I can only guess what using: "composite" does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be more gentle in the email clients when failures happen (which usually happen for all tests anyway).
The commondata tests are separated because since they are mostly independent from the rest.