Skip to content

Implementation of ATLAS WPWM 8TeV - excluded from 4.0#2411

Open
vschutze-alt wants to merge 10 commits intomasterfrom
implement_ATLAS_WPWM_8TEV
Open

Implementation of ATLAS WPWM 8TeV - excluded from 4.0#2411
vschutze-alt wants to merge 10 commits intomasterfrom
implement_ATLAS_WPWM_8TEV

Conversation

@vschutze-alt
Copy link
Collaborator

No description provided.

@vschutze-alt vschutze-alt changed the title [WIP] Implementation of ATLAS WPWM 8TeV - excluded from 4.0 Implementation of ATLAS WPWM 8TeV - excluded from 4.0 Dec 16, 2025
@vschutze-alt vschutze-alt marked this pull request as draft December 16, 2025 14:42
@vschutze-alt vschutze-alt requested a review from enocera December 16, 2025 14:42
@scarlehoff
Copy link
Member

fwiw, for the error, rebase on top of master (you can use the button "update with rebase" here) and submit the bot with the "regenerate-data" label

@vschutze-alt vschutze-alt force-pushed the implement_ATLAS_WPWM_8TEV branch from 661a963 to 81e6e54 Compare December 22, 2025 15:50
@vschutze-alt vschutze-alt marked this pull request as ready for review December 22, 2025 17:39
Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one the grids are already available: https://github.com/NNPDF/theories_slim/pull/64
so you can add the theory to the commondata file (and even create the fktable and test the implementation!)

@vschutze-alt
Copy link
Collaborator Author

Regarding the luminosity uncertainty in this dataset, I can see that the paper mentions that the luminosity uncertainty is 1.9%, but I cannot identify any of the uncertainties in the helpdata files as the luminosity uncertainty. Does this mean that I have to add it myself manually? Thanks!

@enocera
Copy link
Contributor

enocera commented Feb 23, 2026

Regarding the luminosity uncertainty in this dataset, I can see that the paper mentions that the luminosity uncertainty is 1.9%, but I cannot identify any of the uncertainties in the helpdata files as the luminosity uncertainty. Does this mean that I have to add it myself manually? Thanks!

Yes!

@vschutze-alt vschutze-alt force-pushed the implement_ATLAS_WPWM_8TEV branch from d058352 to 99181a4 Compare March 13, 2026 10:00
@ecole41
Copy link
Collaborator

ecole41 commented Mar 13, 2026

@enocera @juanrojochacon I have re-run the data-theory plots using the grids in theories_slim and using this branch with the new fix to the shifts. We are seeing a good agreement:
imageimage

However the $\chi^2$ values are very large:

Exp chi2: 132.5
Exp+th chi2: 99.62
Exp+th+pdf chi2: 52.56

Do you understand why this may be?

@juanrojochacon
Copy link

Thanks @ecole41 this is weird: from the shifted plots one can compute the chi2 almost by hand, and should be of order 1 per data point. At least once PDF errors are accounted for.

@juanrojochacon
Copy link

So it seems to me that the chi2 values are not consistent with what is being shown in the data vs theory comparison plot?

@enocera
Copy link
Contributor

enocera commented Mar 13, 2026

@ecole41 What's the blue uncertainty in your plots? The PDF uncertainty, the MHOU uncertainty or the sum in quadrature of the two? The shift does include only the effect of experimental correlations. But in principle there are also PDF and theory correlations that are not currently accounted in the shift. So it could be (and this happens, e.g. for the ATLAS ZpT 13 TeV data set) that the chi2 would be of order one once you incorporate only the diagonal term of the theory covariance matrix (which I guess is what is displayed in your plots).

@ecole41
Copy link
Collaborator

ecole41 commented Mar 13, 2026

@ecole41 What's the blue uncertainty in your plots? The PDF uncertainty, the MHOU uncertainty or the sum in quadrature of the two? The shift does include only the effect of experimental correlations. But in principle there are also PDF and theory correlations that are not currently accounted in the shift. So it could be (and this happens, e.g. for the ATLAS ZpT 13 TeV data set) that the chi2 would be of order one once you incorporate only the diagonal term of the theory covariance matrix (which I guess is what is displayed in your plots).

I am not so sure which uncertainties are included in the blue points. This is plotted using the plot_fancy function in the API script to plot grids, I believe that it only included a standard error across replica predictions (PDF uncertainties). But it would be a good idea to clarify this with e.g @scarlehoff

@juanrojochacon
Copy link

Well we should be able to know exactly what goes on into the plots, else we are in trouble.

As far as I understand, the shifted data vs theory comparison plots include only PDF uncertainties.

The value Exp chi2: 132.5 is consistent with the plot, but not those of the chi2 once MHOU and PDF errors are accounted for. Considering only central PDF errors brings the chi2 down to 1, as @enocera indicates.

I would be very surprised if accounting for PDF corrections makes the chi2 increase so dramatically.

So there is something that we need to understand here.

@scarlehoff
Copy link
Member

Indeed, plot_fancy includes only PDF errors.
For theory uncertainties you must use e.g.,

{@ plot_fancy_sv_dataspecs @}

@scarlehoff
Copy link
Member

scarlehoff commented Mar 17, 2026

@ecole41 please repeat the plot with plot_fancy_sv_dataspecs (you might need to add the **config that is added to the chi2 for that)

norm_threshold might be useful as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants