Conversation
achiefa
approved these changes
Jan 11, 2026
Contributor
There was a problem hiding this comment.
Hi @scarlehoff, thanks for this. It looks good to me for now. Maybe we can open an issue just to remind ourselves that we need to make the NNPDF codebase compatible with the new ruemel version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruamel.yamlhas updated to version 0.19, changes a few things internally, but most importantly there's a change of library that makes it incompatible with some LHAPDF info files.I don't know whether the reason is they are badly formatted or a bug in ruamel, before investigating that I've just modified the dependences to install the old parser which should be ok for now.
This is the reason for the recent errors in the CI e.g.,. https://github.com/NNPDF/nnpdf/actions/runs/20849541813/job/59901073339?pr=2393#step:4:443