Remove unnecessary methods from the Python API

Author: Radonirinaunimi

pineappl_py/src/boc.rs

@@ -274,17 +274,6 @@ impl PyChannel {
         }
     }
 
-    /// Get the factors for all the channels.
-    ///
-    /// Returns
-    /// -------
-    /// list(float) :
-    ///     list containing the factor values
-    #[must_use]
-    pub fn factors(&self) -> Vec<f64> {
-        self.entry.entry().iter().map(|(_, f)| *f).collect()
-    }
-
     /// Get list representation.
     ///
     /// Returns

pineappl_py/src/fk_table.rs

@@ -175,22 +175,6 @@ impl PyFkTable {
         self.fk_table.channels()
     }
 
-    /// Extract the factors from all the channels.
-    ///
-    /// Returns
-    /// -------
-    /// list(float) :
-    ///     list containing the factor values
-    #[must_use]
-    pub fn channels_factors(&self) -> Vec<f64> {
-        self.fk_table
-            .grid()
-            .channels()
-            .iter()
-            .flat_map(|entry| entry.entry().iter().map(|(_, f)| *f))
-            .collect()
-    }
-
     /// Get squared factorization scale.
     ///
     /// Returns

pineappl_py/src/grid.rs

@@ -692,21 +692,6 @@ impl PyGrid {
             .collect()
     }
 
-    /// Extract the factors from all the channels.
-    ///
-    /// Returns
-    /// -------
-    /// list(float) :
-    ///     list containing the factor values
-    #[must_use]
-    pub fn channels_factors(&self) -> Vec<f64> {
-        self.grid
-            .channels()
-            .iter()
-            .flat_map(|entry| entry.entry().iter().map(|(_, f)| *f))
-            .collect()
-    }
-
     /// Deduplicate channels
     ///
     /// Parameters

pineappl_py/tests/test_boc.py

@@ -62,12 +62,10 @@ def test_init(self):
         channel = Channel([([2, -2], 0.5)])
         assert isinstance(channel, Channel)
         assert channel.into_array() == [([2, -2], 0.5)]
-        assert channel.factors() == [0.5]
 
         channels = Channel([([2, -2], 0.5), ([3, -3], 1.5)])
         assert isinstance(channels, Channel)
         assert channels.into_array() == [([2, -2], 0.5), ([3, -3], 1.5)]
-        assert channels.factors() == [0.5, 1.5]
 
 
 class TestKinematics:

pineappl_py/tests/test_fk_table.py

@@ -127,15 +127,9 @@ def test_fktable_rotations(
         fk_table = download_objects(f"{fkname}")
         fk = FkTable.read(fk_table)
 
-        # record the channel factors and check they are unity
-        fk_evol_facs = fk.channels_factors()
-        np.testing.assert_array_equal(fk_evol_facs, 1)
-
         # rotate in the PDG basis and check that all the factors are unity
         fk.rotate_pid_basis(PidBasis.Pdg)
         assert fk.pid_basis == PidBasis.Pdg
-        fk_pdg_facs = fk.channels_factors()
-        np.testing.assert_array_equal(fk_pdg_facs, 1)
 
         # check that the convolutions are still the same
         np.testing.assert_allclose(

pineappl_py/tests/test_grid.py

@@ -417,21 +417,13 @@ def test_grid_rotations(
         grid = download_objects(f"{gridname}")
         g = Grid.read(grid)
 
-        # record the channel factors and check that some factors are not `1`
-        g_pdf_facs = g.channels_factors()
-        with pytest.raises(expected_exception=AssertionError):
-            np.testing.assert_array_equal(g_pdf_facs, 1)
-
         # rotate in the Evolution basis
         g.rotate_pid_basis(PidBasis.Evol)
         assert g.pid_basis == PidBasis.Evol
 
         # merge the factors and check that the channels are to unity
         g.split_channels()
         g.merge_channel_factors()
-        # optimize the grid to remove duplicate channels
-        g_facs = g.channels_factors()
-        np.testing.assert_array_equal(g_facs, 1)
 
         # check that the convolutions are still the same
         np.testing.assert_allclose(