-
Notifications
You must be signed in to change notification settings - Fork 0
Convert ROOT, APPLgrid, and fastNLO tables into PineAPPL with Nix #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe, in nixpkgs
applgridis stuck at 1.4.70 only becausexfitterwanted (used to?) root5. Or, maybe, there was a format incompatibility for applgrid root files. If you want, feel free to submit an update for the package, then you'll be able to use it here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @veprbl, thanks for the comment. The nixpkgs of
APPLgridindeed is stuck atv1.4.70because ofROOT5. I don't think however that the reason is because of some incompatibilities betweenAPPLgridand root files as what we are doing right now is exactly performing the conversionROOT(->APPLgrid)->PineAPPL.I might indeed consider doing this if/whenever I have some spare time. However, I haven't submitted anything to the
nixpkgsyet and therefore not sure how the process exactly works and whether it'd take a huge amount of effort and time to get something passed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A regular PR will suffice. Feel free to ping me for review.