Enable g2int and int outputs for jpeg decoding with OpenJPEG#591
Merged
edwardhartnett merged 7 commits intoNOAA-EMC:developfrom Mar 12, 2025
Merged
Enable g2int and int outputs for jpeg decoding with OpenJPEG#591edwardhartnett merged 7 commits intoNOAA-EMC:developfrom
edwardhartnett merged 7 commits intoNOAA-EMC:developfrom
Conversation
AlysonStahl-NOAA
requested review from
DusanJovic-NOAA and
edwardhartnett
and removed request for
DusanJovic-NOAA
DusanJovic-NOAA
approved these changes
Mar 10, 2025
edhartnett
reviewed
Mar 12, 2025
edhartnett
approved these changes
Mar 12, 2025
edwardhartnett
approved these changes
Mar 12, 2025
Contributor
|
Do we need to do a release now? If so, @AlysonStahl-NOAA please add an issue... |
Contributor
Author
|
Yes, just opened one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NOAA-EMC/NCEPLIBS-g2#825 (I think it was opened there in error)
Fixes NOAA-EMC/wgrib2#345
This capability already exists for Jasper decoding.
This PR creates a static function
int_dec_jpeg2000()which now performs the jpeg decoding, but accepts the variableout_is_g2int. The functiondec_jpeg2000()now callsint_dec_jpeg2000()without_is_g2int = 1.