Skip to content

[develop] Remove production runtime dependencies on sorc/ directory#4732

Merged
DavidHuber-NOAA merged 3 commits intodevelopfrom
copilot/remove-dependencies-on-sorc-directory
Mar 31, 2026
Merged

[develop] Remove production runtime dependencies on sorc/ directory#4732
DavidHuber-NOAA merged 3 commits intodevelopfrom
copilot/remove-dependencies-on-sorc-directory

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 31, 2026 •
edited by DavidHuber-NOAA
Loading

Description

Production jobs reference files directly in sorc/ at runtime, causing failures if sorc/ is removed after deployment. Four files had hardcoded sorc/ paths:

sorc/link_workflow.sh — added missing links to production locations:

  • fd_ufs.yaml → parm/ufs/
  • suite_*.xml CCPP suite files → parm/ufs/
  • UPP modulefiles directory → modulefiles/upp/
  • chgres_cube added to ufs_utils exec list → exec/

Runtime scripts updated to use linked locations:

  • ush/forecast_predet.sh — CCPP suite path → ${HOMEglobal}/parm/ufs/
  • ush/parsing_ufs_configure.sh — fd_ufs.yaml → ${HOMEglobal}/parm/ufs/
  • dev/scripts/exglobal_atmos_chgres_gen_control.sh — chgres_cube → ${EXECglobal}/
  • modulefiles/gw_upp.wcoss2.lua — MODULEPATH → modulefiles/upp/

Refs #4731

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Verified no remaining sorc/ references in modified runtime scripts
  • shellcheck validation on all modified shell scripts

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copilot AI linked an issue Mar 31, 2026 that may be closed by this pull request
the model should not point into the sorc/ directory in production runs #4731
Open
@DavidHuber-NOAA
Remove production runtime dependencies on sorc/ directory
326ab06 
Add missing links in link_workflow.sh for fd_ufs.yaml, CCPP suite
files, UPP modulefiles, and chgres_cube executable. Update scripts
to reference files from parm/ufs/, modulefiles/, and exec/ instead
of sorc/.

Agent-Logs-Url: https://github.com/NOAA-EMC/global-workflow/sessions/f0cf46c1-4b10-437d-9104-dfdb166d1914

Co-authored-by: DavidHuber-NOAA <69919478+DavidHuber-NOAA@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix model dependencies on sorc directory in production runs Remove production runtime dependencies on sorc/ directory Mar 31, 2026
Copilot AI requested a review from DavidHuber-NOAA March 31, 2026 12:04
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review March 31, 2026 12:25
@DavidHuber-NOAA DavidHuber-NOAA changed the title Remove production runtime dependencies on sorc/ directory [develop] Remove production runtime dependencies on sorc/ directory Mar 31, 2026
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

DavidHuber-NOAA commented Mar 31, 2026

Launching CI on Hercules.

@emcbot emcbot added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Mar 31, 2026
@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

DavidHuber-NOAA commented Mar 31, 2026

All tests passed on Hercules. Merging.

@DavidHuber-NOAA DavidHuber-NOAA merged commit 9059804 into develop Mar 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA DavidHuber-NOAA is a code owner

@CarlosMDiaz-NCO CarlosMDiaz-NCO Awaiting requested review from CarlosMDiaz-NCO

@dpsarmie dpsarmie Awaiting requested review from dpsarmie dpsarmie is a code owner

@TravisElless-NOAA TravisElless-NOAA Awaiting requested review from TravisElless-NOAA TravisElless-NOAA is a code owner

Assignees

@DavidHuber-NOAA DavidHuber-NOAA

Copilot code review Copilot

Labels

CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

the model should not point into the sorc/ directory in production runs

4 participants

@DavidHuber-NOAA @CoryMartin-NOAA @emcbot