Skip to content

Quick hot fix for compval #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilaflott merged 2 commits into from
Jul 30, 2025
Merged

Quick hot fix for compval #128

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7874191
Fixing path to json file
Jul 28, 2025
174c935
v2.0.1. -> v2.0.2
Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion catalogbuilder/tests/compval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import re
import math
import logging
from importlib.resources import files
import urllib.request

logger = logging.getLogger('local')
Expand Down Expand Up @@ -147,7 +148,8 @@ def compval(json_path,json_template_path, vocab, proper_generation, test_failure
if json_template_path:
json_template = json.load(open(json_template_path))
else:
json_template = json.load(open('catalogbuilder/cats/gfdl_template.json'))
jpath = files('catalogbuilder').joinpath('cats/gfdl_template.json')
json_template = json.load(open(jpath))

#Validate JSON against JSON template
comp = (diff(j,json_template))
Expand Down