Conversation
|
@underwoo, a quick review please :) |
| . ${srcdir=.}/init.sh; path_prepend_ ../src | ||
|
|
||
| # Set paths to list-vars script and just-compiled exec | ||
| export LIST_NCVARS=`find ../.. -name list_ncvars.sh` |
There was a problem hiding this comment.
These should be added to the Makefile.am where the test environment is defined, not here.
There was a problem hiding this comment.
This is true for all other files.
PR #338 has a fix for the PKGLIBEXECDIR. Please work to have that merged as well.
| ? $ENV{LIST_NCVARS} | ||
| : "$prefix/bin/list_ncvars.sh"; | ||
|
|
||
| unless (-f $list_ncvars) { |
There was a problem hiding this comment.
A test scripot is required to ensure this line does what you expect.
Also, only testing if the file exists is not sufficient. You do need to verify the command runs. It would be easier to verify that the command ran successfully in the location where the command is run in this script than just trying to figure out if the command exits and is executable.
There was a problem hiding this comment.
Thank you very much. I that checking the exit status would be better than this check, and I'll do that in a separate PR.
|
#338 resolves the split-vars test failures in a far better way, so closing this with prejudice. |
Description
The new split-ncvars tests cannot find the just-built script and executable location.
This resolves that problem and does not add any new functionality.
Fixes #353
How Has This Been Tested?
Hand-tested, and CI tests will pass
Checklist:
make distcheckpasses