Skip to content

Restore split_ncvars.pl splitting behavior post NCO 5.1.9#373

Merged
ceblanton merged 2 commits intomainfrom
372.split-vars
Feb 4, 2026
Merged

Restore split_ncvars.pl splitting behavior post NCO 5.1.9#373
ceblanton merged 2 commits intomainfrom
372.split-vars

Conversation

@ceblanton
Copy link
Copy Markdown
Contributor

Description
NCO tools 5.1.9 changed the behavior of ncks to include more referenced variables in the split-out files. These extra variables turn out to be undesired FRE users, so this reverts to the previous behavior.

Fixes #372

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@ceblanton
Copy link
Copy Markdown
Contributor Author

@mlee03 I'm sure we want this but I'll admit I didn't make a compelling case yet

@ceblanton ceblanton requested a review from underwoo August 28, 2025 23:28
Also: update site config files for sw 2025.01
@ceblanton ceblanton merged commit 3907451 into main Feb 4, 2026
8 checks passed
ceblanton pushed a commit that referenced this pull request Feb 17, 2026
Only omit them when generating the statics with single-file option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

split_ncvars.pl is including unintended referenced variables

2 participants